Merge lp:~cwilson/spud/window_open_bugfix into lp:spud

Proposed by Cian Wilson
Status: Merged
Merged at revision: 534
Proposed branch: lp:~cwilson/spud/window_open_bugfix
Merge into: lp:spud
Diff against target: 20 lines (+5/-5)
1 file modified
diamond/bin/diamond (+5/-5)
To merge this branch: bzr merge lp:~cwilson/spud/window_open_bugfix
Reviewer Review Type Date Requested Status
Patrick Farrell Approve
Review via email: mp+129516@code.launchpad.net

Description of the change

Fixes sloppy indentation in diamond/bin/diamond

To post a comment you must log in.
Revision history for this message
Patrick Farrell (pefarrell) wrote :

I don't understand the monster that diamond/bin/diamond has become, but I trust you, Cian!

review: Approve
Revision history for this message
Cian Wilson (cwilson) wrote :

Thanks Patrick!

I don't understand it at all either but just looking at the diff for r533 its pretty clear that the try/except went in at the wrong indentation level.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'diamond/bin/diamond'
2--- diamond/bin/diamond 2012-09-22 15:00:03 +0000
3+++ diamond/bin/diamond 2012-10-12 21:02:20 +0000
4@@ -273,11 +273,11 @@
5 else:
6 plugins.configure_plugins(suffix)
7
8- try:
9- i = interface.Diamond(gladefile = gladefile, logofile = logofile, suffix = suffix)
10- except Exception, e:
11- debug.deprint('Error: ' + str(e), 0)
12- i = interface.Diamond(gladefile = gladefile, suffix = suffix)
13+ try:
14+ i = interface.Diamond(gladefile = gladefile, logofile = logofile, suffix = suffix)
15+ except Exception, e:
16+ debug.deprint('Error: ' + str(e), 0)
17+ i = interface.Diamond(gladefile = gladefile, suffix = suffix)
18
19 i.main_window.window.set_cursor(gtk.gdk.Cursor(gtk.gdk.WATCH))
20 i.open_file(schemafile = input_schemafile, filename = input_filename)

Subscribers

People subscribed via source and target branches