Merge lp:~cwayne/unity-scope-home/rename-to-home into lp:unity-scope-home

Proposed by Chris Wayne
Status: Merged
Approved by: Paweł Stołowski
Approved revision: 168
Merged at revision: 169
Proposed branch: lp:~cwayne/unity-scope-home/rename-to-home
Merge into: lp:unity-scope-home
Diff against target: 11 lines (+1/-1)
1 file modified
data/home.scope.in.in (+1/-1)
To merge this branch: bzr merge lp:~cwayne/unity-scope-home/rename-to-home
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Paweł Stołowski (community) Approve
Matt Fischer (community) Approve
Review via email: mp+187862@code.launchpad.net

Commit message

Changing the title from Home Scope to Home

Description of the change

The title should be 'Home' not 'Home Scope', that is confusing for users

To post a comment you must log in.
Revision history for this message
Matt Fischer (mfisch) wrote :

Did you test this on a device by modifying the home scope file?

Revision history for this message
Chris Wayne (cwayne) wrote :

Yes I did, and it worked as expected

Revision history for this message
Matt Fischer (mfisch) wrote :

+1 from me since you stated you tested it on IRC>

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:168
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~cwayne18/unity-scope-home/rename-to-home/+merge/187862/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/unity-scope-home-ci/93/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-home-saucy-amd64-ci/57
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-home-saucy-armhf-ci/57
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-home-saucy-i386-ci/57/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-scope-home-ci/93/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Paweł Stołowski (stolowski) wrote :

+1

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)
Revision history for this message
Adolfo Jayme Barrientos (fitojb) wrote :

This string change is untrasnlatable as the POT file wasn't updated...

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/home.scope.in.in'
2--- data/home.scope.in.in 2013-03-19 16:53:49 +0000
3+++ data/home.scope.in.in 2013-09-26 17:53:51 +0000
4@@ -5,7 +5,7 @@
5 RequiredMetadata=
6 OptionalMetadata=
7 Type=home
8-_Name=Home Scope
9+_Name=Home
10 Description=Unity Home Scope
11 _SearchHint=Search your computer and online sources
12

Subscribers

People subscribed via source and target branches

to all changes: