Merge lp:~cwayne/ubuntu-touch-customization-hooks/system-settings-import into lp:ubuntu-touch-customization-hooks

Proposed by Chris Wayne
Status: Merged
Approved by: Scott Sweeny
Approved revision: 33
Merged at revision: 34
Proposed branch: lp:~cwayne/ubuntu-touch-customization-hooks/system-settings-import
Merge into: lp:ubuntu-touch-customization-hooks
Diff against target: 13 lines (+3/-0)
1 file modified
usr/share/upstart/sessions/custom-env.conf (+3/-0)
To merge this branch: bzr merge lp:~cwayne/ubuntu-touch-customization-hooks/system-settings-import
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Scott Sweeny (community) Approve
Review via email: mp+235068@code.launchpad.net

Commit message

Set QML2_IMPORT_PATH so that MMI plugins can work

Description of the change

Set QML2_IMPORT_PATH so that MMI plugins can work

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Scott Sweeny (ssweeny) wrote :

Why do we only want to do this if MMI plugins are present in /custom?

Revision history for this message
Chris Wayne (cwayne) wrote :

Because those are private API's that are only used within system-settings and the MMI plugins, so it shouldn't be set system-wide unless something outside of system-settings (MMI plugins in this case) needs them

Revision history for this message
Scott Sweeny (ssweeny) wrote :

Is there a way we can just set the import path for those plugins without doing it globally in this case?

Revision history for this message
Chris Wayne (cwayne) wrote :

None that I know of

Revision history for this message
Scott Sweeny (ssweeny) wrote :

How is it done in a non-custom image?

Revision history for this message
Chris Wayne (cwayne) wrote :

It's all set globally, looks like in /etc/environment, and it's always only set to 1 path

Revision history for this message
Scott Sweeny (ssweeny) wrote :

Alright then.

review: Approve
33. By Chris Wayne

Set import path within /custom instead of using prviate system-settings APIs

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'usr/share/upstart/sessions/custom-env.conf'
2--- usr/share/upstart/sessions/custom-env.conf 2013-09-23 16:49:35 +0000
3+++ usr/share/upstart/sessions/custom-env.conf 2014-09-18 21:42:23 +0000
4@@ -17,6 +17,9 @@
5 if [ -d /custom/usr/share/themes ]; then
6 initctl set-env --global UBUNTU_UI_TOOLKIT_THEMES_PATH=/custom/usr/share/themes
7 fi
8+ if [ -d /custom/usr/share/dialer-app/MMI ]; then
9+ initctl set-env --global QML2_IMPORT_PATH=/usr/lib/arm-linux-gnueabihf/qt5/imports:/custom/usr/lib/arm-linux-gnueabihf/qt5/imports/
10+ fi
11 end script
12
13 # vim:syntax=upstart

Subscribers

People subscribed via source and target branches