Merge lp:~cvetomir-todorov/nunitv2/bug524474 into lp:nunitv2
Proposed by
Cvetomir Todorov
Status: | Merged |
---|---|
Approved by: | Charlie Poole |
Approved revision: | 3202 |
Merge reported by: | Charlie Poole |
Merged at revision: | not available |
Proposed branch: | lp:~cvetomir-todorov/nunitv2/bug524474 |
Merge into: | lp:nunitv2 |
Diff against target: |
110 lines (+56/-3) 4 files modified
src/ConsoleRunner/tests/nunit-console.tests.build (+1/-0) src/GuiComponents/UiKit/TestTree.cs (+7/-3) src/GuiComponents/tests/TestTreeTests.cs (+47/-0) src/GuiComponents/tests/nunit.uikit.tests.csproj (+1/-0) |
To merge this branch: | bzr merge lp:~cvetomir-todorov/nunitv2/bug524474 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Charlie Poole | Approve | ||
Review via email: mp+34638@code.launchpad.net |
To post a comment you must log in.
The reflection is ugly of course, but it seems like a good way to get a test without having to do some
major redesign right now. We should do it more cleanly in 3.0 but right now this seems like a smart use of time.
Only one issue... this line...
string[ ] expectedSelecte dCategories = new[] { "Foo", "MockCategory" };
...requires C# 3.0 to compile.
If the entire test only works under C# 3.0, then it should be inside an #if CS_3_0.
In this case, we want the test to work under C# 2.0, so the initialization needs to
use the older syntax. However, it's so small, I'll just do it when I do the merge.
Approved! Thanks.
Charlie