Odoo Web (MOVED TO GITHUB)

Merge lp:~cv.clearcorp/openerp-web/lp-986407-Bad-URL-for-gravatar-in-the-kanban-view into lp:openerp-web/6.1

  1. lp-986407-Bad-URL-for-gravatar-in-the-kanban-view
  2. Merge into 6.1
Proposed by Carlos Vásquez (ClearCorp)
Status: Rejected
Rejected by: Antony Lesuisse (OpenERP)
Proposed branch: lp:~cv.clearcorp/openerp-web/lp-986407-Bad-URL-for-gravatar-in-the-kanban-view
Merge into: lp:openerp-web/6.1
Diff against target: 13 lines (+2/-1)
1 file modified
addons/web_kanban/static/src/js/kanban.js (+2/-1)
To merge this branch: bzr merge lp:~cv.clearcorp/openerp-web/lp-986407-Bad-URL-for-gravatar-in-the-kanban-view
Reviewer Review Type Date Requested Status
Antony Lesuisse (OpenERP) Disapprove
Review via email: mp+103572@code.launchpad.net

Description of the change

See the linked bug report

To post a comment you must log in.
Revision history for this message
Antony Lesuisse (OpenERP) (al-openerp) wrote :

Gravatar is deprecated.

See comment on bug https://bugs.launchpad.net/bugs/894800

review: Disapprove

Unmerged revisions

2311. By Carlos Vásquez (ClearCorp)

[FIX] lp 986407: Bad URL for gravatar in the kanban view / gravatar not refreshing properly

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web_kanban/static/src/js/kanban.js'
2--- addons/web_kanban/static/src/js/kanban.js 2012-02-22 11:37:18 +0000
3+++ addons/web_kanban/static/src/js/kanban.js 2012-04-25 21:19:18 +0000
4@@ -552,7 +552,8 @@
5 email = _.str.trim(email || '').toLowerCase();
6 var default_ = _.str.isBlank(email) ? 'mm' : 'identicon';
7 var email_md5 = $.md5(email);
8- return 'http://www.gravatar.com/avatar/' + email_md5 + '.png?s=' + size + '&d=' + default_;
9+ var today = new Date();
10+ return 'http://www.gravatar.com/avatar/' + email_md5 + '.png?s=' + size + '&d=' + default_ + '&date=' + today.format("m-d-Y");
11 },
12 kanban_image: function(model, field, id) {
13 id = id || '';