Code review comment for lp:~ctf/checkbox/bug811177

Hi Daniel,
cpufreq-selector is in the package: gnome-applets which is not the
default package in Oneiric.
Actually in the cpu_scaling_test script, while
setParameterWithSelector(using cpufreq-selector) failed, it will run
setParameter(change governor using echo to sys file), so even we saw
the cpufreq-selector error, it is still working.
My patch is a fix to the problem that the cpufreq sys file location is
changed in Oneiric, I use findParameter() to search the sys file, so
it will backward compatible.

I have reviewed the source code of cpufreq-selector, I think it's ok
to make a checkbox-version cpufreq-selector, but since the
cpu_scaling_test is working without cpufreq-selector(we may remove the
error message).
Do we still need that? Please let me know your idea, thanks.

On Wed, Sep 21, 2011 at 3:57 AM, Daniel Manrique
<email address hidden> wrote:
> Review: Needs Information
>
> Hi Tim,
>
> I ran the script on a Natty system and it works fine, however on Oneiric it still fails due to absence of cpufreq-selector. When run, the test produces output as seen here:
>
> http://paste.ubuntu.com/693991/
>
> The exit code is 1, indicating failure (and as the output shows, "Error: performance setting vs minimum of 58.1% is not within 10.0% margin").
>
> Do you know of a way to replace cpufreq-selector? I think once we have that we can consider this fixed, but we're still missing that one part (even though the test now runs, it will fail most of the time).
>
> Thanks!
>
> --
> https://code.launchpad.net/~ctf/checkbox/bug811177/+merge/75683
> You are the owner of lp:~ctf/checkbox/bug811177.
>

--
Tim