Merge lp:~cszikszoy/do/contactitem-remove into lp:do

[Chris S.]

[lp:~cszikszoy/do/contactitem-remove]

1095. By Chris S. on 2009-03-14

add function to merge contacts

[Alex Launi (alexlauni)]

I don't see this as a useful feature. Do already merges contacts with the same name, if you want them merged you should so in the application. This also breaks a central part of the Do philosophy which is that you should never be using Do to use Do. Do should always be a means to another end. If an ItemSource does not allow you to set an alias for a contact then that's a bug in the application and should be fixed upstream. We shouldn't break the zen of Do for these unwieldy applications.

review: Disapprove

Unmerged revisions

1095. By Chris S. on 2009-03-14

add function to merge contacts

1094. By Chris S. on 2009-03-14

add function to check if contact exists

1093. By Chris S. on 2009-03-14

allow for the removal of a contact item

=== modified file 'Do.Universe/src/Do.Universe/ContactItem.cs'
--- Do.Universe/src/Do.Universe/ContactItem.cs	2008-12-20 00:31:54 +0000
+++ Do.Universe/src/Do.Universe/ContactItem.cs	2009-03-14 09:53:44 +0000
@@ -57,6 +57,30 @@
 			}
 			return contact;
 		}
+
+		public static bool RemoveContact (ContactItem contact)
+		{
+			return RemoveContact (contact["name"].ToLower ());
+		}
+		
+		public static bool RemoveContact (string name)
+		{
+			if (Exists (name)) {
+				return (contacts_name.Remove (name)) ? true : false;
+			}
+			else
+				return false;
+		}
+		
+		public static bool Exists (ContactItem contact)
+		{
+			return Exists (contact["name"].ToLower ());
+		}
+		
+		public static bool Exists (string name)
+		{
+			return contacts_name.ContainsKey (name);
+		}
 		
 		protected Dictionary<string,string> details;