Merge lp:~cszikszoy/do-plugins/skype-rewrite into lp:do-plugins

Proposed by Chris S.
Status: Merged
Merged at revision: not available
Proposed branch: lp:~cszikszoy/do-plugins/skype-rewrite
Merge into: lp:do-plugins
To merge this branch: bzr merge lp:~cszikszoy/do-plugins/skype-rewrite
Reviewer Review Type Date Requested Status
Alex Launi (community) Needs Fixing
Review via email: mp+12564@code.launchpad.net

This proposal supersedes a proposal from 2009-09-28.

To post a comment you must log in.
Revision history for this message
Chris S. (cszikszoy) wrote : Posted in a previous version of this proposal

Complete rewrite of the skype plugin. Removed a bunch of unused crap.

The only actions I kept were call, chat and set status. I couldn't really justify keeping the other ones (like browse previous chats).

Revision history for this message
Alex Launi (alexlauni) wrote :

Skype.cs:101-113 - It's kind of silly to throw an exception that you catch yourself.

other than that it looks ok

review: Needs Fixing

Subscribers

People subscribed via source and target branches