Merge lp:~cruzjbishop/loggerhead/ui-changes into lp:loggerhead

[Cruz Bishop]

Some small UI changes

Extra border at the bottom of file diffs
Rounded borders

Some minor UI changes.

1: Rounded borders on the info box
2: Border at the bottom of each file diff, in order to properly show the end of each file when scrolled to the right / reading the right hand side
3: Rounded the borders at the top of each file diff's header

Screenshots: (Used one of my project repositories to test it)

http://imgur.com/a/C7jNL

[Cruz Bishop (cruzjbishop)]

Please note that you may have to clear the browser's cache to see any changes.

[Richard Harding (rharding)]

Cruz, can you please attach a screenshot of the changes for the merge proposal? Technically the changes look ok, but I'm going to have curtis review as well as an official UI reviewer.

review: Approve (code*)

[j.c.sackett (jcsackett)]

I'm glad to see diffs replacing the browser-specific rounded corners with the css3 defaults, since we're finally moving to those.

Thanks.

review: Approve

[Cruz Bishop (cruzjbishop)]

Sure, I'll just be a few minutes

[Cruz Bishop (cruzjbishop)]

Hi Richard,

I added a link to a 'gallery' of screenshots. I can't see any link to directly attach them, so let's hope you can all access it! :)

Thank you both

[j.c.sackett (jcsackett)]

Cruz--

Curtis took a look, but since I have this open right now I'm commenting.

We would like to standardize on 5px for the rounded edges in both LP and loggerhead. Could you please set that to 5px in this branch, and then I will land it for you?

review: Needs Fixing

[j.c.sackett (jcsackett)]

I misread the diff earlier. We can also probably drop the -webkit and -moz properties; the official property has been adopted by mozilla and webkit.

[Cruz Bishop (cruzjbishop)]

Sure thing, I'll do those now

[lp:~cruzjbishop/loggerhead/ui-changes]

477. By Cruz Bishop on 2012-03-09

Fixes for Curtis and J.C.Sackett

478. By Cruz Bishop on 2012-03-09

Get rid of some white space

[j.c.sackett (jcsackett)]

Thanks, this looks good.

review: Approve

=== modified file 'loggerhead/static/css/diff.css'
--- loggerhead/static/css/diff.css	2012-02-22 08:43:19 +0000
+++ loggerhead/static/css/diff.css	2012-03-09 06:16:18 +0000
@@ -6,6 +6,7 @@
     color: #666;
     background: #fcfcfc url(../images/bg_infobox.gif) repeat-y top right;
     border: 1px solid #b7b7b7;
+    border-radius: 5px; 
     }
 ul#list-files {
     float: right;
@@ -37,6 +38,7 @@
     background: #eef6fa;
     border: 1px solid #d2d2d2;
     margin: 10px 0 0 0;
+    border-radius: 5px 5px 5px 0px;
     }
 .diffBox img {
     vertical-align: middle;
@@ -49,6 +51,7 @@
     }
 .diffinfo {
     overflow: hidden;
+    border-bottom: 1px solid #d5d5d5;
     }
 .lineNumber {
     width: 2%;