Merge lp:~cruzjbishop/loggerhead/UI-Round-1 into lp:loggerhead

Proposed by Cruz Bishop on 2012-09-21
Status: Merged
Merged at revision: 486
Proposed branch: lp:~cruzjbishop/loggerhead/UI-Round-1
Merge into: lp:loggerhead
Diff against target: 39 lines (+4/-2)
2 files modified
loggerhead/static/css/diff.css (+2/-2)
loggerhead/static/css/global.css (+2/-0)
To merge this branch: bzr merge lp:~cruzjbishop/loggerhead/UI-Round-1
Reviewer Review Type Date Requested Status
Benji York (community) code 2012-09-21 Approve on 2012-09-24
Review via email: mp+125621@code.launchpad.net

Commit message

Introduce some more minor UI changes

Description of the change

This merge request pulls in some minor UI changes to do with rounded corners.

The changes are as follows:

1: Introduce more natural looking borders in the info box. http://i.imgur.com/U9mRu.png

2: Make the "file diff" (for lack of a better name) header more tab-like in appearance. http://i.imgur.com/U9mRu.png

3: Give top-level menu entries rounded corners. http://i.imgur.com/YzI8f.png and http://i.imgur.com/8CgbG.png

To post a comment you must log in.
Benji York (benji) wrote :

I had a hard time deciding whether or not eliding the vendor-prefixed versions of the rounding directives is acceptable here. I just barely came down on the side of leaving them out, but if me mentioning it spurs you to put them in, I won't complain.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'loggerhead/static/css/diff.css'
--- loggerhead/static/css/diff.css 2012-03-28 20:45:44 +0000
+++ loggerhead/static/css/diff.css 2012-09-21 02:32:18 +0000
@@ -6,7 +6,7 @@
6 color: #666;6 color: #666;
7 background: #fcfcfc url(../images/bg_infobox.gif) repeat-y top right;7 background: #fcfcfc url(../images/bg_infobox.gif) repeat-y top right;
8 border: 1px solid #b7b7b7;8 border: 1px solid #b7b7b7;
9 border-radius: 5px; 9 border-radius: 13px / 7px;
10 }10 }
11ul#list-files {11ul#list-files {
12 float: right;12 float: right;
@@ -39,7 +39,7 @@
39 background: #eef6fa;39 background: #eef6fa;
40 border: 1px solid #d2d2d2;40 border: 1px solid #d2d2d2;
41 margin: 10px 0 0 0;41 margin: 10px 0 0 0;
42 border-radius: 5px 5px 5px 0px;42 border-radius: 5px 5px 8px 0px / 17px 17px 5px 0px;
43 }43 }
44.diffBox img {44.diffBox img {
45 vertical-align: middle;45 vertical-align: middle;
4646
=== modified file 'loggerhead/static/css/global.css'
--- loggerhead/static/css/global.css 2011-11-23 17:21:39 +0000
+++ loggerhead/static/css/global.css 2012-09-21 02:32:18 +0000
@@ -131,11 +131,13 @@
131ul#menuTabs li a:hover {131ul#menuTabs li a:hover {
132 background-color: #f3f3f3;132 background-color: #f3f3f3;
133 text-decoration: none;133 text-decoration: none;
134 border-radius: 5px;
134 }135 }
135ul#menuTabs li a#on {136ul#menuTabs li a#on {
136 font-weight: bold;137 font-weight: bold;
137 color: #fff;138 color: #fff;
138 background-color: #747474;139 background-color: #747474;
140 border-radius: 5px;
139 }141 }
140142
141/* Sub-menu Tabs */143/* Sub-menu Tabs */

Subscribers

People subscribed via source and target branches