Merge lp:~cruzjbishop/loggerhead/Fix-258368 into lp:loggerhead

Proposed by Cruz Bishop on 2012-09-20
Status: Merged
Merged at revision: 485
Proposed branch: lp:~cruzjbishop/loggerhead/Fix-258368
Merge into: lp:loggerhead
Diff against target: 19 lines (+1/-1)
1 file modified
loggerhead/static/css/diff.css (+1/-1)
To merge this branch: bzr merge lp:~cruzjbishop/loggerhead/Fix-258368
Reviewer Review Type Date Requested Status
Benji York (community) code 2012-09-20 Approve on 2012-09-24
Review via email: mp+125602@code.launchpad.net

Description of the change

This merge request fixes bug #258368

Previously, in the revision information box, only the information half had word-wrap applied. Now, the entire box (including files added/modified/removed) is wrapped.

I decided to use the Netty project (for which I am maintaining a Github->Launchpad relationship) as an example.

A random commit before this merge:

http://i.imgur.com/1QUN0.png

Another random commit after this merge:

http://i.imgur.com/1Qeet.png

To post a comment you must log in.
Benji York (benji) wrote :

Looks good.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'loggerhead/static/css/diff.css'
2--- loggerhead/static/css/diff.css 2012-03-28 20:45:44 +0000
3+++ loggerhead/static/css/diff.css 2012-09-20 23:09:19 +0000
4@@ -7,6 +7,7 @@
5 background: #fcfcfc url(../images/bg_infobox.gif) repeat-y top right;
6 border: 1px solid #b7b7b7;
7 border-radius: 5px;
8+ word-wrap: break-word;
9 }
10 ul#list-files {
11 float: right;
12@@ -30,7 +31,6 @@
13 margin: 0 0 5px 0;
14 font-size: 77%;
15 color: #666;
16- word-wrap: break-word;
17 }
18 /*Diff Boxes*/
19 .diffBox {

Subscribers

People subscribed via source and target branches