Merge lp:~cristiklein/usb-creator/use-xdg into lp:usb-creator

[Cristian Klein]

[Cristian Klein (cristiklein)]

It is not "polite" to dump the user's home dir with .usb-creator.log. Instead, usb-creator should respect the XDG Base Directory Specification [1] and put this file in $XDG_CACHE_HOME/usbcreator/usbcreator.log.

[1] http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html

[Dimitri John Ledkov (xnox)]

There are a few places where we reffer to that log file, e.g. the most important one that I have found is the apport hook. So this needs further fixing. I will look into that in a few weeks =) I'm fan of XDG-basedir spec so this will be done in the upcoming releases.

review: Needs Fixing

Unmerged revisions

=== modified file 'usbcreator/misc.py'
--- usbcreator/misc.py	2009-10-13 09:53:07 +0000
+++ usbcreator/misc.py	2009-11-20 10:15:22 +0000
@@ -40,8 +40,10 @@
     log = logging.getLogger('')
     # usb-creator used to write ~/.usb-creator.log as root (whoops!), so lets
     # use a different name here.
-    log_dir = os.path.expanduser('~')
-    log_file = os.path.join(log_dir, '.usbcreator.log')
+    cache_dir = os.getenv('XDG_CACHE_HOME', os.path.expanduser('~/.cache'))
+	log_dir = os.path.join(cache_dir, 'usbcreator')
+	os.makedirs(log_dir)
+    log_file = os.path.join(log_dir, 'usbcreator.log')
     handler = None
     try:
         handler = logging.handlers.RotatingFileHandler(log_file,