Merge ~cristiangsp/launchpad:fixing-test_filebug_dupefinderjs-linting into launchpad:master

Proposed by Cristian Gonzalez
Status: Merged
Approved by: Cristian Gonzalez
Approved revision: 371625f8ba31e63b95385e290068929e1a25d3d7
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cristiangsp/launchpad:fixing-test_filebug_dupefinderjs-linting
Merge into: launchpad:master
Diff against target: 29 lines (+6/-6)
1 file modified
lib/lp/bugs/javascript/tests/test_filebug_dupefinder.js (+6/-6)
Reviewer Review Type Date Requested Status
Colin Watson Approve
Review via email: mp+407005@code.launchpad.net

Commit message

Fixing test_filebug_dupefinder.js linting

Description of the change

Fixing test_filebug_dupefinder.js linting

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/bugs/javascript/tests/test_filebug_dupefinder.js b/lib/lp/bugs/javascript/tests/test_filebug_dupefinder.js
2index eb85aff..e7159f1 100644
3--- a/lib/lp/bugs/javascript/tests/test_filebug_dupefinder.js
4+++ b/lib/lp/bugs/javascript/tests/test_filebug_dupefinder.js
5@@ -24,18 +24,18 @@ YUI.add('lp.bugs.filebug_dupefinder.test', function (Y) {
6 throw new Error("Constructor called as a function");
7 }
8 this.calls = [];
9- this.io = function(url, config) {
10+ this.io = function io_handler(url, config) {
11 this.calls.push(url);
12 var response = {responseText: ''};
13 // We may have been passed text to use in the response.
14- if (Y.Lang.isValue(arguments.callee.responseText)) {
15- response.responseText = arguments.callee.responseText;
16+ if (Y.Lang.isValue(io_handler.responseText)) {
17+ response.responseText = io_handler.responseText;
18 }
19 // We currently only support calling the success handler.
20- config.on.success(undefined, response, arguments.callee.args);
21+ config.on.success(undefined, response, io_handler.args);
22 // After calling the handler, resume the test.
23- if (Y.Lang.isFunction(arguments.callee.doAfter)) {
24- test_case.resume(arguments.callee.doAfter);
25+ if (Y.Lang.isFunction(io_handler.doAfter)) {
26+ test_case.resume(io_handler.doAfter);
27 }
28 };
29 }

Subscribers

People subscribed via source and target branches

to status/vote changes: