Merge ~cristiangsp/launchpad:fixing-formoverlayjs-linting into launchpad:master

Proposed by Cristian Gonzalez
Status: Merged
Approved by: Cristian Gonzalez
Approved revision: e7e344e4a758772908981f57e064f44a920ec7ff
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cristiangsp/launchpad:fixing-formoverlayjs-linting
Merge into: launchpad:master
Diff against target: 19 lines (+3/-0)
1 file modified
lib/lp/app/javascript/formoverlay/formoverlay.js (+3/-0)
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+406983@code.launchpad.net

Commit message

Fixing linting in formoverlay.js file

Description of the change

Fixing linting in formoverlay.js file

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/app/javascript/formoverlay/formoverlay.js b/lib/lp/app/javascript/formoverlay/formoverlay.js
2index cd3481e..bb5ef75 100644
3--- a/lib/lp/app/javascript/formoverlay/formoverlay.js
4+++ b/lib/lp/app/javascript/formoverlay/formoverlay.js
5@@ -516,11 +516,14 @@ Y.extend(FormOverlay, Y.lp.ui.PrettyOverlay, {
6 case 'file':
7 // stub case as XMLHttpRequest will only send
8 // the file path as a string.
9+ break;
10 case undefined:
11 // stub case for fieldset element which returns
12 // undefined.
13+ break;
14 case 'reset':
15 // stub case for input type reset button.
16+ break;
17 case 'button':
18 // stub case for input type button elements.
19 break;

Subscribers

People subscribed via source and target branches

to status/vote changes: