Launchpad itself

Merge ~cristiangsp/launchpad:fixing-autocompletejs-linting into launchpad:master

  1. Git
  2. lp:~cristiangsp/launchpad
  3. fixing-autocompletejs-linting
  4. Merge into master
Proposed by Cristian Gonzalez
Status: Merged
Approved by: Cristian Gonzalez
Approved revision: 462e1505b075574d7be4b548628c7bd2af8253fa
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cristiangsp/launchpad:fixing-autocompletejs-linting
Merge into: launchpad:master
Diff against target: 49 lines (+5/-5)
1 file modified
lib/lp/app/javascript/autocomplete.js (+5/-5)
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+406982@code.launchpad.net

Commit message

Fixing linting in autocomplete.js file

Description of the change

Fixing linting in autocomplete.js file

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/app/javascript/autocomplete.js b/lib/lp/app/javascript/autocomplete.js
2index b808eba..1f35175 100644
3--- a/lib/lp/app/javascript/autocomplete.js
4+++ b/lib/lp/app/javascript/autocomplete.js
5@@ -9,7 +9,7 @@ YUI.add('lp.app.autocomplete', function (Y) {
6 namespace.getRepositoryCompletionURI = function (repo_node) {
7 var entered_uri = repo_node.get('value');
8 if (entered_uri.startsWith("lp:")) {
9- var split = "+code/" + entered_uri.split("lp:")[1]
10+ var split = "+code/" + entered_uri.split("lp:")[1];
11 entered_uri = encodeURI(split);
12 }
13 else if (entered_uri.startsWith("~")) {
14@@ -29,7 +29,7 @@ YUI.add('lp.app.autocomplete', function (Y) {
15 uri += entered_uri;
16 uri += '/@@+huge-vocabulary';
17 return uri;
18- }
19+ };
20
21 namespace.getRepoNode = function (path_node) {
22 var split = path_node._node['id'].split('.');
23@@ -37,7 +37,7 @@ YUI.add('lp.app.autocomplete', function (Y) {
24 var repository_target = split.join('.');
25 var target_repo = Y.one('[id="' + repository_target + '"]');
26 return target_repo;
27- }
28+ };
29
30 namespace.getPathNode = function (path_node) {
31 var split = path_node._node['id'].split('.');
32@@ -45,7 +45,7 @@ YUI.add('lp.app.autocomplete', function (Y) {
33 var path_target = split.join('.');
34 var target_path = Y.one('[id="' + path_target + '"]');
35 return target_path;
36- }
37+ };
38
39 namespace.setupVocabAutocomplete = function (config, node) {
40 var qs = 'name=' + encodeURIComponent(config.vocabulary_name);
41@@ -72,7 +72,7 @@ YUI.add('lp.app.autocomplete', function (Y) {
42 var uri = namespace.getRepositoryCompletionURI(this);
43 var path_node = namespace.getPathNode(this);
44 path_node.ac.set("source", uri);
45- }
46+ };
47 // ideally this should take node to rebind `this` in the function
48 // but we're also calling it from the popup picker, which has a direct
49 // reference to the repo_node, so maintain the local `this` binding.

Subscribers

People subscribed via source and target branches

to status/vote changes: