Merge lp:~credativ/ocb-server/7.0-no-workers-no-listen into lp:ocb-server
Status: | Rejected |
---|---|
Rejected by: | Holger Brunn (Therp) |
Proposed branch: | lp:~credativ/ocb-server/7.0-no-workers-no-listen |
Merge into: | lp:ocb-server |
Diff against target: |
94 lines (+19/-15) 3 files modified
openerp/cli/server.py (+1/-1) openerp/service/workers.py (+17/-13) openerp/tools/config.py (+1/-1) |
To merge this branch: | bzr merge lp:~credativ/ocb-server/7.0-no-workers-no-listen |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Holger Brunn (Therp) | Disapprove | ||
Review via email: mp+217744@code.launchpad.net |
Description of the change
Do not bind sockets when starting with no workers
If wanting to run the OpenERP server split out to a cron worker and a main server, the cron worker daemon must not try to bind the server socket.
This commit lets an explicit --workers=0 mean that we still want to run multiprocess, but are not going to listen anywhere.
Rationale for raising directly against OCB:
The "openerp-server" script has been removed in favor of the "oe" script not long after 7 has been released, therefore I presume OpenERP would not be interested in integrating this into 7.0 maintenance.
Unmerged revisions
- 5328. By mistotebe
-
[IMP] Do not bind sockets when not starting with any workers
If wanting to run the OpenERP server split out to a cron worker and a main
server, the cron worker daemon must not try to bind the server socket.This commit lets an explicit --workers=0 mean that we still want to run
multiprocess, but are not going to listen anywhere.
Development for 7.0 has moved to github on https:/ /github. com/OCA/ ocb - please move your merge proposal there if it is still valid.
(I close and reject this in order to have a cleaner overview for 6.1 MPs which indeed have to be done on launchpad)