Merge lp:~credativ/ocb-addons/7.0-rounding-fix-cost-price into lp:ocb-addons

Proposed by Jacob Hicks (credativ)
Status: Rejected
Rejected by: Holger Brunn (Therp)
Proposed branch: lp:~credativ/ocb-addons/7.0-rounding-fix-cost-price
Merge into: lp:ocb-addons
Diff against target: 27 lines (+5/-1)
2 files modified
product/product.py (+1/-1)
product/product_data.xml (+4/-0)
To merge this branch: bzr merge lp:~credativ/ocb-addons/7.0-rounding-fix-cost-price
Reviewer Review Type Date Requested Status
Holger Brunn (Therp) Disapprove
Ana Juaristi Olalde (community) code review Abstain
Omar (Pexego) code review Disapprove
Review via email: mp+212197@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Omar (Pexego) (omar7r) wrote :

Hi,

I think that must stay as "Product Price" because, price unit field in purchase lines, uses "Product Price" too and for average cost price, is important that these fields match in digits

review: Disapprove (code review)
Revision history for this message
Ana Juaristi Olalde (ajuaristio) wrote :

Doubt about fix and Omar's comment.

review: Abstain (code review)
Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

Development for 7.0 has moved to github on https://github.com/OCA/ocb - please move your merge proposal there if it is still valid.

(I close and reject this in order to have a cleaner overview for 6.1 MPs which indeed have to be done on launchpad)

review: Disapprove

Unmerged revisions

10033. By Jacob Hicks (credativ)

[IMP] Product : Decimal precision of product Cost Price changed to 'Purchase Price' to allow greater precision

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'product/product.py'
2--- product/product.py 2014-03-14 17:09:35 +0000
3+++ product/product.py 2014-03-21 16:58:51 +0000
4@@ -304,7 +304,7 @@
5 'rental': fields.boolean('Can be Rent'),
6 'categ_id': fields.many2one('product.category','Category', required=True, change_default=True, domain="[('type','=','normal')]" ,help="Select category for the current product"),
7 'list_price': fields.float('Sale Price', digits_compute=dp.get_precision('Product Price'), help="Base price to compute the customer price. Sometimes called the catalog price."),
8- 'standard_price': fields.float('Cost', digits_compute=dp.get_precision('Product Price'), help="Cost price of the product used for standard stock valuation in accounting and used as a base price on purchase orders.", groups="base.group_user"),
9+ 'standard_price': fields.float('Cost', digits_compute=dp.get_precision('Purchase Price'), help="Cost price of the product used for standard stock valuation in accounting and used as a base price on purchase orders.", groups="base.group_user"),
10 'volume': fields.float('Volume', help="The volume in m3."),
11 'weight': fields.float('Gross Weight', digits_compute=dp.get_precision('Stock Weight'), help="The gross weight in Kg."),
12 'weight_net': fields.float('Net Weight', digits_compute=dp.get_precision('Stock Weight'), help="The net weight in Kg."),
13
14=== modified file 'product/product_data.xml'
15--- product/product_data.xml 2012-10-23 16:05:04 +0000
16+++ product/product_data.xml 2014-03-21 16:58:51 +0000
17@@ -165,6 +165,10 @@
18 <field name="name">Product Price</field>
19 <field name="digits">2</field>
20 </record>
21+ <record forcecreate="True" id="decimal_purchase" model="decimal.precision">
22+ <field name="name">Purchase Price</field>
23+ <field name="digits">6</field>
24+ </record>
25 <record forcecreate="True" id="decimal_discount" model="decimal.precision">
26 <field name="name">Discount</field>
27 <field name="digits">2</field>