Merge ~crass/casper:fix-showmounts into casper:main

[Glenn Washburn]

Fix a bug that made the initrd parameter "showmounts" not work as intended (at all from a user perspective). Also, allow user access to the upperdir of the overlayfs, aka cow fs, as used to be the case.

Unmerged commits

941ba2b... by Glenn Washburn on 2023-10-04

Have show-cow actually show the cow dir

Until commit 40489842 ("Drop exposing /cow tree"), the upperdir of the
overlayfs of the live cd was exposed as /cow. Confusingly that commit
states that "because /cow is tmpfs, one cannot actually move it". This
is incorrect, the mount --move works fine. This patch conditionally
reinstates the previous behavior, when "showmounts" or "show-cow" is
a kernel parameter. Instead of putting the cow in the root directory, as
was previously done, it is put with the rest of the mounts made user
accessible via the afore mentioned kernel parameters.

65a8188... by Glenn Washburn on 2023-10-04

Fix showmounts which was broken due to a typo

diff --git a/scripts/casper b/scripts/casper
index 36a724d..b0fc62d 100644
--- a/scripts/casper
+++ b/scripts/casper
@@ -699,9 +699,12 @@ setup_overlay() {
     fi
 
     if [ -n "${SHOWMOUNTS}" ]; then
+        mkdir -p "${rootmnt}/${LIVE_MEDIA_PATH}/cow"
+        mount --bind /cow "${rootmnt}/${LIVE_MEDIA_PATH}/cow"
+
         for d in ${rofslist}; do
             mkdir -p "${rootmnt}/${LIVE_MEDIA_PATH}/${d##*/}"
-            case d in
+            case "$d" in
                 *.dir) # do nothing # mount -o bind "${d}" "${rootmnt}/${LIVE_MEDIA_PATH}/${d##*/}"
                     ;;
                 *)