Code review comment for lp:~craighewetson-deactivatedaccount/bzr-explorer/shorten-refresh-time

Revision history for this message
Alexander Belchenko (bialix) wrote :

Craig, why you voted "Resubmit"? In Launchpad terms it means you asking yourself to rework the patch. Instead you should change status of proposal from "Work In Progress" to "Needs Review".

Anyway, I need something to put into NEWS file about this improvement.

Also, your changes for QBzr will be merged into QBzr 0.20. If it helps you can check the version of QBzr and don't block it if QBzr version < 0.20?

Another question: while Close button is not active user should still be able to close the dialog with Alt+F4 or Close icon in the dialog title. Can you check that it still works?

review: Needs Fixing

« Back to merge proposal