Code review comment for ~craftyjon/kicad:bus_upgrades_merge
Revision history for this message
| Seth Hillbrand (sethh) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
> The major issues I see here are:
> 1) ERC validation
> 2) deterministic netlisting
>
> But I think that there is maybe a commit missing in this as I don't see the
> changes in sch_edit_frame.h that would be needed.
* Scratch the note about a commit being missing. I see at the end, launchpad has "helpfully" truncated the diff because it was too large. So this is only part of the merge. Ugh. I'm really looking forward to GitLab.