Merge lp:~cr3/checkbox/printable into lp:checkbox

[Marc Tardif]

[Daniel Manrique (roadmr)]

Awesome, fixes a problem I was having. Thanks!

review: Approve

=== modified file 'debian/changelog'
--- debian/changelog	2011-12-06 22:08:08 +0000
+++ debian/changelog	2011-12-07 21:38:25 +0000
@@ -14,6 +14,7 @@
   * Refactored install script to be agnostic of variant name.
   * Using title defined in user_interface plugin in GTK interface.
   * Updated default.whitelist to reflect renamed jobs.
+  * Removed files with non-printable characters from submission.xml.
   
   [Daniel Manrique]
   * Update control files under debian/ to eliminate (most) lintian warnings

=== modified file 'plugins/launchpad_report.py'
--- plugins/launchpad_report.py	2011-10-13 19:53:56 +0000
+++ plugins/launchpad_report.py	2011-12-07 21:38:25 +0000
@@ -19,6 +19,7 @@
 import os
 
 from gettext import gettext as _
+from string import printable
 
 from checkbox.lib.safe import safe_make_directory
 
@@ -80,7 +81,7 @@
             elif "udev_attachment" in name:
                 self._report["hardware"]["udev"] = attachment["data"]
 
-            else:
+            elif all(c in printable for c in attachment["data"]):
                 self._report["context"].append({
                     "command": attachment["command"],
                     "data": attachment["data"]})