Merge lp:~cr3/checkbox/hwtest into lp:checkbox

Proposed by Marc Tardif
Status: Merged
Merged at revision: 1213
Proposed branch: lp:~cr3/checkbox/hwtest
Merge into: lp:checkbox
Diff against target: 232 lines (+13/-105)
9 files modified
.bzrignore (+0/-3)
debian/changelog (+1/-0)
debian/control (+0/-31)
debian/hwtest-cli.postinst (+0/-7)
debian/hwtest-gtk.postinst (+0/-7)
debian/hwtest.postinst (+0/-7)
debian/hwtest.postrm (+0/-26)
debian/rules (+0/-6)
install/postinst (+12/-18)
To merge this branch: bzr merge lp:~cr3/checkbox/hwtest
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+91102@code.launchpad.net

Description of the change

Tested sbuilding the changes which was successful. Also made sure that the hwtest packages were no longer being built.

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

Awesome, let's hope nobody still needs hwtest :)

Merging, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '.bzrignore'
2--- .bzrignore 2011-12-07 04:34:49 +0000
3+++ .bzrignore 2012-02-01 15:07:39 +0000
4@@ -10,9 +10,6 @@
5 debian/*.debhelper
6 debian/files
7 debian/*-gtk.postrm
8-debian/hwtest
9-debian/hwtest-cli
10-debian/hwtest-gtk
11 debian/*.log
12 debian/stamp-patched
13 debian/*.substvars
14
15=== modified file 'debian/changelog'
16--- debian/changelog 2012-01-31 20:04:09 +0000
17+++ debian/changelog 2012-02-01 15:07:39 +0000
18@@ -37,6 +37,7 @@
19 and context info (LP: #912546)
20 * Added support for skipping tests when the depends don't pass
21 (LP: #509598)
22+ * Removed deprecated hwtest package.
23
24 [Daniel Manrique]
25 * Update control files under debian/ to eliminate (most) lintian warnings
26
27=== modified file 'debian/control'
28--- debian/control 2012-01-31 01:23:23 +0000
29+++ debian/control 2012-02-01 15:07:39 +0000
30@@ -11,22 +11,16 @@
31 Package: checkbox
32 Section: python
33 Architecture: any
34-Replaces: hwtest (<< 0.1-0ubuntu12)
35-Provides: hwtest
36 Depends: ${misc:Depends}, ${python:Depends}, debconf, python-libxml2, udev
37 Recommends: dpkg (>= 1.13), gstreamer0.10-gconf, lsb-release, perl, pm-utils, python-apport, python-apt, python-dateutil, python-gst0.10
38 Suggests: checkbox-cli | checkbox-gtk, bonnie++, bootchart, bzr, cvs, ethtool, flex, fwts, git-core, hdparm, lshw, make, nmap, obexd-client, python-pexpect, smartmontools, sox, stress, wodim
39-Conflicts: hwtest (<< 0.1-0ubuntu12)
40 Description: System testing application
41 This project provides an extensible interface for system testing. The
42 results can then be sent to Launchpad.
43
44 Package: checkbox-cli
45 Architecture: all
46-Replaces: hwtest-cli (<< 0.1-0ubuntu12)
47-Provides: hwtest-cli
48 Depends: checkbox (>= ${source:Version}), ${misc:Depends}
49-Conflicts: hwtest-cli (<< 0.1-0ubuntu12)
50 Description: Command line interface for checkbox
51 This project provides an extensible interface for system testing. The
52 results can then be sent to Launchpad.
53@@ -46,10 +40,7 @@
54 Package: checkbox-gtk
55 Section: gnome
56 Architecture: all
57-Replaces: hwtest-gtk (<< 0.1-0ubuntu12)
58-Provides: hwtest-gtk
59 Depends: checkbox (>= ${source:Version}), gksu, python-gobject (>= 2.28), gir1.2-gtk-3.0, ${misc:Depends}
60-Conflicts: hwtest-gtk (<< 0.1-0ubuntu12)
61 Description: GTK interface for checkbox
62 This project provides an extensible interface for system testing. The
63 results can then be sent to Launchpad.
64@@ -64,25 +55,3 @@
65 results can then be sent to Launchpad.
66 .
67 This package provides a non-interactive interface for SRU testing.
68-
69-Package: hwtest
70-Section: python
71-Architecture: all
72-Depends: checkbox, ${misc:Depends}
73-Description: Transitional package to checkbox
74- This package is a transitional package for renaming hwtest to checkbox.
75-
76-Package: hwtest-cli
77-Architecture: all
78-Depends: checkbox-cli, ${misc:Depends}
79-Description: Transitional package to checkbox-cli
80- This package is a transitional package for renaming hwtest-cli to
81- checkbox-cli.
82-
83-Package: hwtest-gtk
84-Section: gnome
85-Architecture: all
86-Depends: checkbox-gtk, ${misc:Depends}
87-Description: Transitional package to checkbox-gtk
88- This package is a transitional package for renaming hwtest-gtk to
89- checkbox-gtk.
90
91=== removed file 'debian/hwtest-cli.postinst'
92--- debian/hwtest-cli.postinst 2011-11-29 20:22:12 +0000
93+++ debian/hwtest-cli.postinst 1970-01-01 00:00:00 +0000
94@@ -1,7 +0,0 @@
95-#! /bin/sh -e
96-
97-base_package="checkbox"
98-. /usr/share/debconf/confmodule
99-. /usr/share/checkbox/install/postinst
100-
101-#DEBHELPER#
102
103=== removed file 'debian/hwtest-gtk.postinst'
104--- debian/hwtest-gtk.postinst 2011-11-29 20:22:12 +0000
105+++ debian/hwtest-gtk.postinst 1970-01-01 00:00:00 +0000
106@@ -1,7 +0,0 @@
107-#! /bin/sh -e
108-
109-base_package="checkbox"
110-. /usr/share/debconf/confmodule
111-. /usr/share/checkbox/install/postinst
112-
113-#DEBHELPER#
114
115=== removed file 'debian/hwtest.postinst'
116--- debian/hwtest.postinst 2011-11-29 20:22:12 +0000
117+++ debian/hwtest.postinst 1970-01-01 00:00:00 +0000
118@@ -1,7 +0,0 @@
119-#! /bin/sh -e
120-
121-base_package="checkbox"
122-. /usr/share/debconf/confmodule
123-. /usr/share/checkbox/install/postinst
124-
125-#DEBHELPER#
126
127=== removed file 'debian/hwtest.postrm'
128--- debian/hwtest.postrm 2009-03-25 03:19:48 +0000
129+++ debian/hwtest.postrm 1970-01-01 00:00:00 +0000
130@@ -1,26 +0,0 @@
131-#! /bin/sh -e
132-
133-name=`basename $0 .postrm`
134-base=`echo $name | cut -d "-" -f "1"`
135-file="/etc/$base.d/$name.ini"
136-
137-case "$1" in
138- purge)
139- # mimic dpkg as closely as possible, so remove configuration
140- # files with dpkg backup extensions too:
141- for ext in '~' '%' .bak .dpkg-tmp .dpkg-new .dpkg-old .dpkg-dist; do
142- rm -f $file$ext
143- done
144-
145- # remove the configuration file itself
146- rm -f $file
147- ;;
148- remove|disappear|upgrade|failed-upgrade|abort-install|abort-upgrade)
149- ;;
150- *)
151- echo "$0: didn't understand being called with \`$1'" 1>&2
152- exit 0
153- ;;
154-esac
155-
156-#DEBHELPER#
157
158=== modified file 'debian/rules'
159--- debian/rules 2011-12-07 04:34:49 +0000
160+++ debian/rules 2012-02-01 15:07:39 +0000
161@@ -8,8 +8,6 @@
162 cp debian/checkbox.postrm debian/checkbox-urwid.postrm
163 cp debian/checkbox.postrm debian/checkbox-gtk.postrm
164 cp debian/checkbox.postrm debian/checkbox-sru.postrm
165- cp debian/hwtest.postrm debian/hwtest-cli.postrm
166- cp debian/hwtest.postrm debian/hwtest-gtk.postrm
167 dh_installdeb
168
169 override_dh_installdocs:
170@@ -18,14 +16,10 @@
171 dh_installdocs -pcheckbox-urwid ./README
172 dh_installdocs -pcheckbox-gtk ./README
173 dh_installdocs -pcheckbox-sru ./README
174- dh_installdocs -phwtest ./README
175- dh_installdocs -phwtest-cli ./README
176- dh_installdocs -phwtest-gtk ./README
177 dh_installdocs
178
179 override_dh_clean:
180 -find . -name \*.mo -exec rm {} \;
181 -rm -f debian/checkbox-cli.postrm debian/checkbox-urwid.postrm debian/checkbox-gtk.postrm debian/checkbox-sru.postrm
182- -rm -f debian/hwtest-cli.postrm debian/hwtest-gtk.postrm
183 debconf-updatepo
184 dh_clean
185
186=== modified file 'install/postinst'
187--- install/postinst 2011-11-29 20:22:12 +0000
188+++ install/postinst 2012-02-01 15:07:39 +0000
189@@ -32,10 +32,6 @@
190 # Apply the patch file if it is less than the given version
191 patch_version=`basename $patch_file`
192 if dpkg --compare-versions $version lt $patch_version; then
193- # Package was renamed from hwtest to checkbox
194- dpkg --compare-versions $patch_version lt "0.1-ubuntu13" \
195- && patch_package=`echo $package | sed 's/checkbox/hwtest/'` \
196- || patch_package=`echo $package | sed 's/hwtest/checkbox/'`
197 $patch_file $patch_package
198 fi
199
200@@ -47,20 +43,18 @@
201 {
202 root_package=`echo $package | cut -d '-' -f '1'`
203
204- if [ "$root_package" != "hwtest" ]; then
205- # Create a temporary file to generate the suggested
206- # configuration file.
207- tempfile=`tempfile -m 0644 -p checkbox`
208-
209- # Update the temporary file with preseeded values.
210- /usr/share/checkbox/install/config --output=$tempfile $package $base_package
211-
212- # Clobber the old config file.
213- cp $tempfile $config
214-
215- # Now clear up the cruft.
216- rm -f $tempfile
217- fi
218+ # Create a temporary file to generate the suggested
219+ # configuration file.
220+ tempfile=`tempfile -m 0644 -p checkbox`
221+
222+ # Update the temporary file with preseeded values.
223+ /usr/share/checkbox/install/config --output=$tempfile $package $base_package
224+
225+ # Clobber the old config file.
226+ cp $tempfile $config
227+
228+ # Now clear up the cruft.
229+ rm -f $tempfile
230 }
231
232 case "$1" in

Subscribers

People subscribed via source and target branches