Merge lp:~cr3/checkbox/ansi_parser into lp:checkbox

Proposed by Marc Tardif
Status: Merged
Merged at revision: 1436
Proposed branch: lp:~cr3/checkbox/ansi_parser
Merge into: lp:checkbox
Diff against target: 21 lines (+3/-1)
2 files modified
debian/changelog (+2/-0)
scripts/ansi_parser (+1/-1)
To merge this branch: bzr merge lp:~cr3/checkbox/ansi_parser
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Brendan Donegan (community) Needs Information
Review via email: mp+108787@code.launchpad.net

Description of the change

Only needed to change the shebang, 2to3 only proposed one superfluous change.

Tested by piping the output of ls --color to the script, which returned no color!

To post a comment you must log in.
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Should we take the opportunity to switch over to argparse, considering optparse is *supposed* to be deprecated? Just a suggestion

review: Needs Information
Revision history for this message
Marc Tardif (cr3) wrote :

Sure, but I don't think such a nice to have should necessarily block this story from moving forward.

Revision history for this message
Daniel Manrique (roadmr) wrote :

OK, the migration to ArgParse can be done separately. Merging, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-06-01 20:21:47 +0000
3+++ debian/changelog 2012-06-05 17:14:22 +0000
4@@ -10,6 +10,8 @@
5 a test for the Super key.
6 * [FEATURE] Added new interactive and auto-verifying touchpad scrolling
7 test.
8+ * [FEATURE] Python 2 to 3 conversion:
9+ * scripts/ansi_parser
10 * Removed sleep_test script no longer used by any test definition.
11
12 [Daniel Manrique]
13
14=== modified file 'scripts/ansi_parser'
15--- scripts/ansi_parser 2012-05-22 18:01:21 +0000
16+++ scripts/ansi_parser 2012-06-05 17:14:22 +0000
17@@ -1,4 +1,4 @@
18-#!/usr/bin/python
19+#!/usr/bin/python3
20 import sys
21 from optparse import OptionParser
22

Subscribers

People subscribed via source and target branches