Merge lp:~cr3/checkbox/729431 into lp:checkbox

Proposed by Marc Tardif
Status: Merged
Merged at revision: 902
Proposed branch: lp:~cr3/checkbox/729431
Merge into: lp:checkbox
Diff against target: 26 lines (+5/-1)
2 files modified
debian/changelog (+2/-0)
plugins/manual_test.py (+3/-1)
To merge this branch: bzr merge lp:~cr3/checkbox/729431
Reviewer Review Type Date Requested Status
Jeff Lane  Approve
Review via email: mp+56355@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jeff Lane  (bladernr) wrote :

Looks good. Approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-03-30 13:30:52 +0000
3+++ debian/changelog 2011-04-05 13:35:20 +0000
4@@ -1,5 +1,7 @@
5 checkbox (0.11.3) natty; urgency=low
6
7+ * Fixed keyerror when running some manual tests (LP: #729431)
8+
9 [Ara Pulido]
10 * Improved debconf messages and ordering (LP: #553777)
11 * Video bugs should be reported as a display symptom (LP: #744964)
12
13=== modified file 'plugins/manual_test.py'
14--- plugins/manual_test.py 2010-03-07 19:57:57 +0000
15+++ plugins/manual_test.py 2011-04-05 13:35:20 +0000
16@@ -34,7 +34,9 @@
17 # Avoid modifying the content of test in place
18 temp = dict(test)
19 self._manager.reactor.fire("prompt-shell", interface, temp)
20- return (temp["status"], temp["data"], temp["duration"])
21+ return (temp["status"],
22+ temp.get("data", ""),
23+ temp.get("duration", 0))
24
25 interface.show_test(test, runner)
26 self._manager.reactor.fire("prompt-test", interface, test)

Subscribers

People subscribed via source and target branches