Code review comment for lp:~cr3/checkbox/411526

Revision history for this message
Javier Collado (javier.collado) wrote :

Hello,

One more comment, I don't really like the way the suite description text is changed by the capitalize string method because some acronyms (USB, LED, CD/DVD) look weird (Usb, Led, Cd/dvd). If the aim is just to uppercase the first letter in the string, then I'd suggest this change:

=== modified file 'checkbox_gtk/gtk_interface.py'
--- checkbox_gtk/gtk_interface.py 2009-11-05 16:09:25 +0000
+++ checkbox_gtk/gtk_interface.py 2009-11-06 08:36:46 +0000
@@ -265,7 +265,7 @@
         option_table = {}
         vbox = self._get_widget("vbox_options_list")
         for option in options:
- label = "_%s" % option.capitalize()
+ label = "_%s" % (option[0].upper()+option[1:])
             radio_button = gtk.CheckButton(label)
             radio_button.show()
             option_table[option] = radio_button

Best regards,
    Javier

« Back to merge proposal