Merge lp:~cr3/checkbox/1056432 into lp:checkbox

[Marc Tardif]

http://i.imgur.com/06qFl.jpg

[Jeff Marcom (jeffmarcom)]

pending review of lp:~jeffmarcom/checkbox/990560.

[Marc Tardif (cr3)]

Really? The purpose of this branch was to help with your branch, not the other way around. If you need steps to reproduce the problem and validate the branch, the bug related to the branch contains all those details.

[Jeff Marcom (jeffmarcom)]

Looks good. Approve

review: Approve

=== modified file 'debian/changelog'
--- debian/changelog	2012-09-24 15:05:45 +0000
+++ debian/changelog	2012-09-25 20:38:21 +0000
@@ -82,6 +82,7 @@
     fake implementations of build_i18n and build_icons (LP #1049218)
   * checkbox/parsers/description.py: Fixed the PURPOSE and STEPS parts
     of the description parser to automatically fix bad descriptions.
+  * plugins/suites_prompt.py: Fixed tree view in selection window (LP #1056432)
 
   [Sean Feole]
   * [FEATURE] scripts/battery_test: measures battery capacity before and after

=== modified file 'plugins/suites_prompt.py'
--- plugins/suites_prompt.py	2012-08-14 14:30:53 +0000
+++ plugins/suites_prompt.py	2012-09-25 20:38:21 +0000
@@ -114,9 +114,16 @@
         self.store.add_pending_offset(offset)
         tests = dict([(m["name"], m) for m in messages
               if m.get("type") in ("test", "metric")])
+
+        def walk_dependencies(job, all_dependencies):
+            for dependency in resolver.get_dependencies(job)[:-1]:
+                walk_dependencies(dependency, all_dependencies)
+            all_dependencies.append(job)
+
         for job in resolver.get_dependents():
             suboptions = options
-            dependencies = resolver.get_dependencies(job)
+            dependencies = []
+            walk_dependencies(job, dependencies)
             for dependency in dependencies:
                 if dependency in tests:
                     value = tests[dependency]["status"]