Merge lp:~cprov/uci-engine/webui-subtickets into lp:uci-engine

[Celso Providelo]

[lp:~cprov/uci-engine/webui-subtickets]

884. By Celso Providelo on 2014-11-05

Minor CSS adjusting.

885. By Celso Providelo on 2014-11-06

merge trunk

886. By Celso Providelo on 2014-11-06

Invert subtickets rows to avoid text wrapping on its attributes values.

887. By Celso Providelo on 2014-11-06

CSS tweak.

Unmerged revisions

=== modified file 'ci-utils/ci_utils/__init__.py'
--- ci-utils/ci_utils/__init__.py	2014-10-30 17:30:49 +0000
+++ ci-utils/ci_utils/__init__.py	2014-11-05 05:36:04 +0000
@@ -37,6 +37,7 @@
     'precise',
     'trusty',
     'utopic',
+    'vivid',
 ]
 
 

=== modified file 'juju-deployer/configs/unit_config.yaml.tmpl'
--- juju-deployer/configs/unit_config.yaml.tmpl	2014-10-16 09:27:12 +0000
+++ juju-deployer/configs/unit_config.yaml.tmpl	2014-11-05 05:36:04 +0000
@@ -37,6 +37,7 @@
 private_ppas_only: $CI_PRIVATE_PPAS_ONLY
 
 image_map:
+  vivid: http://cloud-images.ubuntu.com/vivid/current/vivid-server-cloudimg-amd64-disk1.img
   utopic: http://cloud-images.ubuntu.com/utopic/current/utopic-server-cloudimg-amd64-disk1.img
   trusty: http://cloud-images.ubuntu.com/trusty/current/trusty-server-cloudimg-amd64-disk1.img
   precise: http://cloud-images.ubuntu.com/precise/current/precise-server-cloudimg-amd64-disk1.img

=== modified file 'ticket_system/ticket/admin.py'
--- ticket_system/ticket/admin.py	2014-10-23 01:21:04 +0000
+++ ticket_system/ticket/admin.py	2014-11-05 05:36:04 +0000
@@ -15,6 +15,7 @@
 
 from django.contrib import admin
 from ticket.models import (
+    MergeProposal,
     Review,
     SourcePackageUpload,
     SubTicket,
@@ -60,10 +61,12 @@
     list_filter = ['name']
     search_fields = ['name']
 
+
+admin.site.register(MergeProposal)
+admin.site.register(Review)
+admin.site.register(SourcePackageUpload, SourcePackageUploadAdmin)
+admin.site.register(SubTicket, SubTicketAdmin)
+admin.site.register(SubTicketArtifact, SubTicketArtifactAdmin)
 admin.site.register(Ticket, TicketAdmin)
-admin.site.register(SubTicket, SubTicketAdmin)
-admin.site.register(SourcePackageUpload, SourcePackageUploadAdmin)
 admin.site.register(TicketArtifact, TicketArtifactAdmin)
-admin.site.register(Review)
-admin.site.register(SubTicketArtifact, SubTicketArtifactAdmin)
 admin.site.register(Workflow, WorkflowAdmin)

=== modified file 'ticket_system/ticket/api.py'
--- ticket_system/ticket/api.py	2014-10-30 04:57:56 +0000
+++ ticket_system/ticket/api.py	2014-11-05 05:36:04 +0000
@@ -136,7 +136,9 @@
             return bundle
 
         for subticket in subtickets:
-            if not isinstance(subticket, dict):
+            if isinstance(subticket, basestring):
+                continue
+            elif not isinstance(subticket, dict):
                 sp = subticket.data['sourcepackage']
             else:
                 sp = subticket['sourcepackage']
@@ -403,7 +405,7 @@
         help_text="Related `SourcePackageUpload`s URIs.")
 
     merge_proposals = fields.ToManyField(
-        'ticket.api.MergeProposalsResource', 'merge_proposals',
+        'ticket.api.MergeProposalResource', 'merge_proposals',
         related_name='subticket', null=True, full=True,
         help_text="Related `MergeProposal`s URIs.")
 
@@ -602,6 +604,7 @@
     class Meta:
         queryset = Review.objects.all()
         authorization = Authorization()
+        allowed_methods = ['get', 'post', 'patch', 'delete']
         filtering = {
             'ticket': ALL_WITH_RELATIONS,
             'review_type': ALL,

=== modified file 'ticket_system/ticket/models.py'
--- ticket_system/ticket/models.py	2014-11-04 09:05:06 +0000
+++ ticket_system/ticket/models.py	2014-11-05 05:36:04 +0000
@@ -99,7 +99,7 @@
         }, {
             'name': 'citrain',
             'steps': json.dumps([
-                {'name': 'silo_creation'},
+                {'name': 'silo_creating'},
                 {'name': 'silo_building'},
                 {'name': 'silo_testing'},
                 {'name': 'silo_publishing'}
@@ -124,7 +124,7 @@
     owner = models.EmailField(max_length=254)
     creator = models.EmailField(max_length=254, null=True, blank=True)
     title = models.CharField(max_length=4096)
-    description = models.TextField()
+    description = models.TextField(blank=True)
     bug_id = models.IntegerField(null=True, blank=True)
     current_workflow_step = models.IntegerField(
         choices=_choices(TicketWorkflowStep), max_length=4096,
@@ -288,7 +288,7 @@
         help_text='Branch revision number approved for this cycle.')
 
     source_package_upload = models.ForeignKey(
-        SourcePackageUpload, null=True,
+        SourcePackageUpload, null=True, blank=True,
         help_text='Current SPU generated by this merge proposal.')
 
     class Meta:
@@ -336,7 +336,8 @@
             ~models.Q(pk=self.ticket.pk),
             ~models.Q(status=TicketWorkflowStepStatus.FAILED),
             current_workflow_step__range=(
-                TicketWorkflowStep.QUEUED, TicketWorkflowStep.PKG_PUBLISHING),
+                TicketWorkflowStep.SILO_BUILDING,
+                TicketWorkflowStep.PKG_PUBLISHING),
         )
 
         return conflicting_tickets
@@ -405,4 +406,4 @@
 
     def __unicode__(self):
         return 'ticket-{} - {}: completed({})'.format(
-            self.ticket.id, self.review_type, self.completed)
+            self.ticket.uuid, self.review_type, self.completed)

=== modified file 'ticket_system/ticket/tests/test_write_api.py'
--- ticket_system/ticket/tests/test_write_api.py	2014-11-04 17:01:32 +0000
+++ ticket_system/ticket/tests/test_write_api.py	2014-11-05 05:36:04 +0000
@@ -135,25 +135,72 @@
             [unicode(spu) for spu in sub_bar.source_package_uploads.all()])
 
     def test_post_ticket_atomically_for_reviews(self):
+        # 'Reviews' can be created atomically with the related `Ticket`.
+
+        # We are injecting a review here to check if tastypie it behaving
+        # correctly and not updating existing reviews to accomplish the
+        # request.
+        other_ticket = create_ticket()
+        existing_review = other_ticket.review_set.create(
+            review_type='QA',
+            workflow_step=TicketWorkflowStep.IMAGE_BUILDING)
+
+        # Let's POST to create a new ticket with pre-defined reviews.
         params = self.post_ticket_data.copy()
         params.update({
             'title': 'Atomic Ticket with Review',
             'reviews': [{
                 'review_type': 'QA',
                 'workflow_step': 'Package validation',
+            }, {
+                'review_type': 'QA',
+                'workflow_step': 'Image building',
             }],
         })
         self.post(resource=self.resource, params=params)
 
         # 'Atomic Ticket with Review' was created.
-        [existing, ticket] = list(Ticket.objects.all())
+        [existing, other, ticket] = list(Ticket.objects.all())
+
         self.assertEqual('Atomic Ticket with Review', unicode(ticket))
-        # and already contain the specified `Review`
-        [review] = list(ticket.review_set.all())
-        self.assertEqual('QA', review.review_type)
-        self.assertEqual(
-            TicketWorkflowStep.PKG_VALIDATION.value, review.workflow_step)
-        self.assertFalse(review.completed)
+        # and already contain the specified `Review`s
+        [review_pkg, review_img] = list(ticket.review_set.all())
+        self.assertEqual('QA', review_pkg.review_type)
+        self.assertEqual(
+            TicketWorkflowStep.PKG_VALIDATION.value, review_pkg.workflow_step)
+        self.assertFalse(review_pkg.completed)
+        self.assertEqual('QA', review_img.review_type)
+        self.assertEqual(
+            TicketWorkflowStep.IMAGE_BUILDING.value, review_img.workflow_step)
+        self.assertFalse(review_img.completed)
+
+        # Note that the reviews created via POST are new, they are not
+        # mysteriously reused/updated by tastypie.
+        self.assertNotIn(existing_review.pk, [review_pkg.pk, review_img.pk])
+
+    def test_patch_ticket_reviews(self):
+        # `Ticket` PATCH can update `Review`s.
+        review = self.ticket.review_set.create(
+            review_type='QA',
+            workflow_step=TicketWorkflowStep.IMAGE_BUILDING)
+
+        params = self.post_ticket_data.copy()
+        params.update({
+            'title': 'Atomic Patched Ticket',
+            'reviews': [{
+                'id': review.id,
+                'completed': True,
+                'workflow_step': 'Image building',
+            }],
+        })
+        self.patch(resource=self.detail_url, params=params)
+
+        # The existing `Subticket` was updated and a new one was created.
+        [ticket] = list(Ticket.objects.all())
+        self.assertEqual('Atomic Patched Ticket', unicode(ticket))
+        [new_review] = list(ticket.review_set.all())
+        self.assertEqual(review.id, new_review.id)
+        self.assertTrue(new_review.completed)
 
     def test_post_ticket_atomically_reuses_workflows(self):
         # `Ticket` atomic creation re-uses existing `Workflows`s.

=== added file 'webui/common/static/common/merge-proposal-icon.png'
Binary files webui/common/static/common/merge-proposal-icon.png	1970-01-01 00:00:00 +0000 and webui/common/static/common/merge-proposal-icon.png	2014-11-05 05:36:04 +0000 differ
=== added file 'webui/common/static/common/warning.png'
Binary files webui/common/static/common/warning.png	1970-01-01 00:00:00 +0000 and webui/common/static/common/warning.png	2014-11-05 05:36:04 +0000 differ
=== modified file 'webui/common/static/common/webui.css'
--- webui/common/static/common/webui.css	2014-11-04 13:32:04 +0000
+++ webui/common/static/common/webui.css	2014-11-05 05:36:04 +0000
@@ -175,18 +175,6 @@
   padding-left: 2em;
 }
 
-td.conflicts a {
-  color: #FF0000;
-  font-style: bold;
-  padding-left: 1em;
-  vertical-align: middle;
-}
-
-td.conflicts img {
-  height: 1em;
-  vertical-align: middle;
-}
-
 div.form-error {
   display: block;
   -moz-border-radius: 4px;
@@ -286,6 +274,25 @@
   font-weight: bold;
 }
 
+/* Subtickets datatable */
+div.subticket_wrapper table {
+  width: 95%;
+  line-height: 2;
+}
+
+div.subticket_wrapper th {
+  background: none;
+  text-align: left;
+  font-weight: bold;
+  border-bottom: 1px solid black;
+}
+
+div.subticket_wrapper td {
+  background: white;
+  text-align: left;
+  border-bottom: 1px dotted black;
+}
+
 /* Ticket inline review. */
 .yui3-inlinereview-content {
   padding: 3px 3px;
@@ -358,3 +365,21 @@
   margin-left: 5px;
   font-size: 10px;
 }
+
+a.mp-link {
+  background-image: url('/static/common/merge-proposal-icon.png');
+  background-repeat: no-repeat;
+  background-size: contain;
+  padding-left: 1.8em;
+  margin-left: 5px;
+  font-size: 10px;
+}
+
+a.conflict-link {
+  background-image: url('/static/common/warning.png');
+  background-repeat: no-repeat;
+  background-size: contain;
+  padding-left: 1.2em;
+  margin-left: 5px;
+  font-size: 10px;
+}

=== modified file 'webui/tickets/static/tickets/webui.js'
--- webui/tickets/static/tickets/webui.js	2014-11-04 13:32:04 +0000
+++ webui/tickets/static/tickets/webui.js	2014-11-05 05:36:04 +0000
@@ -54,9 +54,11 @@
             this.get('srcNode').all('button').on('click', function(e) {
                 var review = self.get('review');
                 var data = {
-                    reviews: [
-                        {'id': review.id, 'completed': true}
-                    ]
+                    reviews: [{
+                        'id': review.id,
+                        'workflow_step': review.workflow_step,
+                        'completed': true
+                    }]
                 };
                 // Issue a PATCH TS-request to update the review and
                 // update the widget accordingly.
@@ -91,14 +93,34 @@
         "The ticket system returned data that could not be understood. " +
         "Please try refreshing, or contact support if this problem " +
         "persists."),
+
         refresh_msg = "Refreshing data...",
+
         default_refresh = 60,
+
         static_prefix = "/static/common/";
+
+        var ticket_status_templates = {
+            completed: ('<img src="{static_prefix}check.svg" ' +
+                        'title="{title}" /></br>'),
+            failed: ('<img src="{static_prefix}cross.svg" ' +
+                     'title="{title}"/></br>'),
+            inprogress: ('<img src="{static_prefix}spinner3.gif" ' +
+                         'title="{title}"/></br>'),
+            paused: ('<img src="{static_prefix}paused.svg" ' +
+                     'title="{title}"/></br>'),
+            'continue': ('<img src="{static_prefix}spinner3.gif" ' +
+                         'title="{title}"/></br>')
+        };
+
     Y.webui = {
+
         url_prefix: "/api/v1/",
+
         refresh_interval: default_refresh * 1000,
+
         refresh_timer: null,
-        done_loading: false,
+
         tempurls: {},
 
         /**
@@ -201,111 +223,6 @@
                 }
             });
         },
-        add_subticket: function (data) {
-            var main_tr = Y.Node.create("<tr>"),
-                key,
-                value,
-                tr;
-
-            main_tr.appendChild(Y.Node.create('<th>subticket</th>'));
-            for (key in data) {
-                if (data.hasOwnProperty(key)) {
-                    value = data[key];
-                    tr = main_tr.appendChild(Y.Node.create('<tr>'));
-                    tr.addClass('subticket');
-                    tr.appendChild(Y.Node.create('<th>' + key + '</th>'));
-                    tr.appendChild(Y.Node.create('<td>' + value + '</td>'));
-                }
-            }
-
-            main_tr.addClass('subticket');
-            return main_tr;
-        },
-        make_subticket: function (data) {
-            var div = Y.Node.create("<div class='subticket'></div>"),
-                table = div.appendChild(Y.Node.create("<table>")),
-                hidden_fields = Y.Array([
-                    'id',
-                    'resource_uri',
-                    'current_workflow_step',
-                    'status',
-                    'sourcepackage',
-                    'merge_proposals',
-                    'source_package_uploads'
-                ]),
-                key,
-                value,
-                tmp_th,
-                tr,
-                count,
-                suffix,
-                span;
-
-            tr = table.appendChild(Y.Node.create('<tr>'));
-            tr.appendChild(Y.Node.create('<th>Current version:</th>'));
-            var td = tr.appendChild(Y.Node.create('<td>-</td>'));
-            var spus = data.source_package_uploads;
-            if (spus.length > 0) {
-                var last_spu = spus[spus.length - 1];
-                td.set('text', last_spu.version);
-            }
-
-            for (key in data) {
-                if (data.hasOwnProperty(key)) {
-                    value = data[key];
-
-                    // Skip hidden fields
-                    if (Y.Array.indexOf(hidden_fields, key) === -1) {
-
-                        suffix = "";
-                        if (key === 'artifact') {
-                            span = Y.webui.add_artifacts(data.artifact);
-                            value = span.getHTML();
-                            count = value.match(/<a/g);
-                            if (count && count.length > 1) {
-                                suffix = "s";
-                            }
-                        }
-
-                        key = key.replace("_", " ");
-                        if (value === null) {
-                            value = "";
-                        }
-
-                        // subticket
-                        tr = table.appendChild(Y.Node.create('<tr>'));
-                        tmp_th = ('<th>' + key.charAt(0).toUpperCase() +
-                                  key.slice(1) + suffix + ': </th>');
-                        tr.appendChild(Y.Node.create(tmp_th));
-                        if (key === 'conflicts') {
-                            // Display 'conflicts' as 'ticket' links.
-                            td = Y.Node.create('<td>')
-                                .addClass('conflicts');
-                            var i;
-                            for (i in value) {
-                                var icon = Y.Node.create('<img>')
-                                    .set('src', '/static/common/cross.svg');
-                                td.appendChild(icon);
-                                var href = value[i].replace('/api/v1', '');
-                                var text = href.replace(
-                                    '/ticket/', '').replace('/', '');
-                                var link = Y.Node.create('<a>')
-                                    .set('href', href)
-                                    .set('text', text);
-                                td.appendChild(link);
-                                td.appendChild('</br>');
-                            }
-                            tr.appendChild(td);
-                        } else {
-                            // Display other fields as plain-text.
-                            tr.appendChild(
-                                Y.Node.create('<td>' + value + '</td>'));
-                        }
-                    }
-                }
-            }
-            return div;
-        },
         basename: function (path) {
             var result = path;
 
@@ -349,6 +266,27 @@
 
             return link;
         },
+
+        /**
+         * Build a link to a Merge Proposal model ({lp_url: 'lp:<MP ref>'}).
+         *
+         * Returns a new <a>.
+         *
+         * @method mp_link
+         */
+
+        mp_link: function (mp) {
+            var link = Y.Node.create('<a/>')
+                .set('text', mp.lp_url)
+                .addClass('mp-link');
+
+            var lp_href = mp.lp_url.replace(
+                'lp:', 'https://code.launchpad.net/');
+            link.set('href', lp_href);
+
+            return link;
+        },
+
         /**
          * Build a link to ppa reference (ppa:<user>/[<distro>/]<name>)
          *
@@ -383,36 +321,14 @@
         },
         ticket_detail_element: function (data) {
             var MAX_DESCRIPTION = 200,
-                count,
-                current_step,
                 description = "",
                 description_p,
                 div,
-                fail_str,
-                found_step,
                 header_description,
                 header_wrapper,
-                i,
-                key,
-                not_yet_step,
-                short_status,
-                skipped_step,
-                span,
-                status_image,
-                step_status,
-                subt,
-                subticket,
-                subticket_count,
                 subticket_wrapper,
-                suffix,
-                table,
-                td,
-                td1,
                 ticket_div,
                 ticket_wrapper,
-                tmp_th,
-                tr,
-                value,
                 workflow_inner_div,
                 workflow_wrapper;
 
@@ -480,27 +396,127 @@
                 dt_details.addRow({'value': watch_log});
             }
 
-            if (data.subticket) {
-                subticket_count = data.subticket.length;
-
-                subticket_wrapper.appendChild("<h3>Uploads</h3>");
-                if (subticket_count > 0) {
-                    for (i = 0; i < subticket_count; i += 1) {
-                        subticket = data.subticket[i];
-
-                        subticket_wrapper.appendChild("<h4>" + data.subticket[i].sourcepackage.name + "</h4><div id='status'><strong>Landing Progress:</strong> " + data.subticket[i].current_workflow_step + " <strong>Status:</strong> " + data.subticket[i].status + "</div>");
-
-                        subt = Y.webui.make_subticket(subticket);
-
-                        subticket_wrapper.appendChild(subt);
-                    }
-                }
-            }
+            // Build and render the subtickets datatable.
+            var dt_subtickets = Y.webui.get_subtickets_datatable(data);
+            dt_subtickets.render(subticket_wrapper);
 
             return div;
         },
 
         /**
+         * Build a datatable for presenting the given Ticket subtickets.
+         *
+         * Returns a Y.Datatable loaded with subtickets.
+         *
+         * @method get_subtickets_datatable
+         */
+        get_subtickets_datatable: function(ticket) {
+            var format_status = function (o) {
+                var template_vars = {
+                    static_prefix: static_prefix, title: o.data.status};
+                var key = o.data.status.replace(' ', '').toLowerCase();
+                if (ticket_status_templates.hasOwnProperty(key)) {
+                    return Y.Lang.sub(
+                        ticket_status_templates[key], template_vars);
+                }
+                // NEW & 'NOT STARTED'.
+                return '-';
+            };
+
+            var format_source = function (o) {
+                return o.data.sourcepackage.name;
+            };
+
+            var format_step = function (o) {
+                return o.data.current_workflow_step;
+            };
+
+            var format_version = function (o) {
+                var last_version = 'Not available'
+                var spus = o.data.source_package_uploads;
+                if (spus.length > 0) {
+                    var last_spu = spus[spus.length - 1];
+                    last_version = last_spu.version;
+                }
+                return last_version
+            };
+
+            var format_assignee = function (o) {
+                return o.data.assignee;
+            };
+
+            var format_mps = function (o) {
+                var container = Y.Node.create('<div>')
+                for (var c in o.data.merge_proposals) {
+                    var mp = o.data.merge_proposals[c]
+                    container.appendChild(Y.webui.mp_link(mp));
+                    container.appendChild('<br>');
+                }
+                return container.getHTML();
+            };
+
+            var format_artifacts = function (o) {
+                var container = Y.Node.create('<div>')
+                for (var c in o.data.artifact) {
+                    var artifact = o.data.artifact[c]
+                    container.appendChild(Y.webui.artifact_link(artifact));
+                    container.appendChild('<br>');
+                }
+                return container.getHTML();
+            };
+
+            var format_conflicts = function (o) {
+                var container = Y.Node.create('<div>')
+                for (var c in o.data.conflicts) {
+                    var href = o.data.conflicts[c].replace('/api/v1', '');
+                    var text = href.replace(
+                        '/ticket/', '').replace('/', '');
+                    var link = Y.Node.create('<a>')
+                        .set('href', href)
+                        .set('text', text)
+                        .addClass('conflict-link');
+                    container.appendChild(link);
+                    container.appendChild('<br>');
+                }
+                return container.getHTML();
+            };
+
+            var dt = new Y.DataTable({
+                columns: [
+                    {key: 'status', label: '&nbsp;',
+                     allowHTML: true, formatter: format_status,
+                     className: 'dt-subticket-status'},
+                    {key: 'source', label: 'Source',
+                     allowHTML: true, formatter: format_source,
+                     className: 'dt-subticket-source'},
+                    {key: 'step', label: 'Step',
+                     allowHTML: true, formatter: format_step,
+                     className: 'dt-subticket-step'},
+                    {key: 'assignee', label: 'Assignee',
+                     allowHTML: true, formatter: format_assignee,
+                     className: 'dt-subticket-assignee'},
+                    {key: 'version', label: 'Current version',
+                     allowHTML: true, formatter: format_version,
+                     className: 'dt-subticket-version'},
+                    {key: 'merge_proposals', label: 'MPs',
+                     allowHTML: true, formatter: format_mps,
+                     className: 'dt-subticket-merge-proposals'},
+                    {key: 'artifacts', label: 'Artifacts',
+                     allowHTML: true, formatter: format_artifacts,
+                     className: 'dt-subticket-artifacts'},
+                    {key: 'conflicts', label: 'Conflicts',
+                     allowHTML: true, formatter: format_conflicts,
+                     className: 'dt-subticket-conflicts'},
+                ],
+                caption: '<h3>Uploads</h3>',
+                data: ticket.subticket
+            });
+
+
+            return dt;
+        },
+
+        /**
          * Build a datatable for presenting the given Ticket status.
          *
          * Returns a Y.Datatable loaded with ticket status.
@@ -532,18 +548,6 @@
                 'Silo publishing': {
                     step: 'silo_publishing', log_prefix: 'silo_publishing'}
             };
-            var icon_templates = {
-                completed: ('<img src="{static_prefix}check.svg" ' +
-                            'title="{title}" /></br>'),
-                failed: ('<img src="{static_prefix}cross.svg" ' +
-                         'title="{title}"/></br>'),
-                inprogress: ('<img src="{static_prefix}spinner3.gif" ' +
-                              'title="{title}"/></br>'),
-                paused: ('<img src="{static_prefix}paused.svg" ' +
-                          'title="{title}"/></br>'),
-                'continue': ('<img src="{static_prefix}spinner3.gif" ' +
-                             'title="{title}"/></br>')
-            };
             var dataset = [];
             var step_values = {};
             var hidden_steps = Y.Array([
@@ -617,14 +621,14 @@
                 if (o.data.value < current_step_value) {
                     // Past steps always 'Passed'.
                     value = Y.Lang.sub(
-                        icon_templates.completed, template_vars);
+                        ticket_status_templates.completed, template_vars);
                 } else if (o.data.value === current_step_value) {
                     // Current step according to the ticket 'status'.
                     o.rowClass = 'dt-status-current';
                     var key = ticket.status.replace(' ', '').toLowerCase();
-                    if (icon_templates.hasOwnProperty(key)) {
+                    if (ticket_status_templates.hasOwnProperty(key)) {
                         value = Y.Lang.sub(
-                            icon_templates[key], template_vars);
+                            ticket_status_templates[key], template_vars);
                     } else {
                         // Just render the text of unexpected statuses.
                         value = ticket.status;