Merge lp:~cprov/uci-engine/webui-reviews into lp:uci-engine

[Celso Providelo]

Handling ticket reviews in the webui ...

Unmerged revisions

868. By Celso Providelo on 2014-10-23

Presenting reviews in the ticket-status section.

=== modified file 'webui/common/static/common/webui.css'
--- webui/common/static/common/webui.css	2014-10-24 18:04:42 +0000
+++ webui/common/static/common/webui.css	2014-10-24 18:04:43 +0000
@@ -279,6 +279,10 @@
   font-weight: bold;
 }
 
+td.dt-status-value select {
+  font-size: small;
+}
+
 /* General links decorators. */
 a.image-link {
   background-image: url('/static/common/cdrom.svg');
@@ -307,3 +311,10 @@
   background-size: contain;
   padding-left: 1.2em;
 }
+
+a.pending-review-link {
+  background-image: url('/static/common/pencil-black.png');
+  background-repeat: no-repeat;
+  background-size: contain;
+  padding-left: 1.2em;
+}

=== modified file 'webui/tickets/static/tickets/webui.js'
--- webui/tickets/static/tickets/webui.js	2014-10-24 18:04:42 +0000
+++ webui/tickets/static/tickets/webui.js	2014-10-24 18:04:43 +0000
@@ -458,6 +458,14 @@
                 'continue': ('<img src="{static_prefix}spinner3.gif" ' +
                              'title="{title}"/></br>')
             };
+            var review_options = [
+                {value: 'Approve', text: 'Approve'},
+                {value: 'Needs Fixing', text: 'Needs Fixing'},
+                {value: 'Needs Info', text: 'Needs Info'},
+                {value: 'Abstain', text: 'Abstain'},
+                {value: 'Disapprove', text: 'Disapprove'},
+                {value: 'Resubmit', text: 'Resubmit'},
+            ];
             var dataset = [];
             var step_values = {};
             var hidden_steps = Y.Array([
@@ -488,6 +496,13 @@
                     // be rendered for citrain tickets.
                     return;
                 }
+                // Collect step reviews.
+                obj.reviews = [];
+                Y.Array.each(ticket.reviews, function(review) {
+                    if (review.workflow_step === obj.name) {
+                        obj.reviews.push(review);
+                    }
+                });
 
                 // Collect related ticket/subticket artifacts.
                 var prefix = 'misc';
@@ -549,6 +564,34 @@
                     value += c.getHTML() + '</br>';
                 });
 
+                // Render related reviews.
+                var review_table = Y.Node.create('<table>')
+                Y.Array.each(o.data.reviews, function (review) {
+                    var label = Y.Node.create('<td>');
+                    label.appendChild(
+                        Y.Node.create('<a>')
+                            .set('text', review.review_type + ':')
+                            .addClass('pending-review-link')
+                    );
+                    var select = Y.Node.create('<select>');
+                    Y.Array.each(review_options, function(opt) {
+                        select.appendChild(
+                            Y.Node.create('<option>')
+                                .set('text', opt.text)
+                                .set('value', opt.value)
+                        );
+                    });
+                    var control = Y.Node.create('<td>');
+                    control.appendChild(select);
+                    var row = Y.Node.create('<tr>');
+                    row.appendChild(label);
+                    row.appendChild(control);
+                    review_table.appendChild(row);
+                });
+                var c = Y.Node.create('<div>');
+                c.appendChild(review_table);
+                value += c.getHTML();
+
                 return value;
             };