Merge lp:~cprov/uci-engine/tr-nova-failures into lp:uci-engine
- tr-nova-failures
- Merge into trunk
Status: | Merged |
---|---|
Approved by: | Celso Providelo |
Approved revision: | 928 |
Merged at revision: | 920 |
Proposed branch: | lp:~cprov/uci-engine/tr-nova-failures |
Merge into: | lp:uci-engine |
Diff against target: |
91 lines (+8/-10) 5 files modified
ci-utils/ci_utils/testing/features.py (+3/-8) juju-deployer/configs/unit_config.yaml.tmpl (+1/-0) test_runner/tstrun/tests/test_run_test.py (+1/-1) test_runner/tstrun/tests/test_worker.py (+2/-0) testing/run_tests.py (+1/-1) |
To merge this branch: | bzr merge lp:~cprov/uci-engine/tr-nova-failures |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ursula Junque (community) | Approve | ||
Vincent Ladeuil (community) | Approve | ||
Review via email: mp+245739@code.launchpad.net |
Commit message
Re-enable TR tests depending on nova-compute feature, adding "autopkgtest" testing feature, but still not using no_skip testing behaviour.
Description of the change
Re-enable TR tests depending on nova-compute, adding "autopkgtest" testing feature.
'no_skip' testing behaviour was not enabled because NovaCredentials (unit_config) and additional deployments (uci-britney) are still not supported in tarmac.
Celso Providelo (cprov) wrote : | # |
Vincent,
Thanks for the quick review, comments addressed.
Vincent Ladeuil (vila) wrote : | # |
Thanks for the quick reply ;)
As mentioned on IRC you will likely have to be patient to activate --no-skip by default.
Approving nevertheless
Ubuntu CI Bot (uci-bot) wrote : | # |
The attempt to merge lp:~cprov/uci-engine/tr-nova-failures into lp:uci-engine failed. Below is the output from the failed tests.
Checking juju status
Private PPAs: disabled
Preparing local branch upload...
Uploading local branch, fingerprint 04fcbf8cf5823ea
Installing keys from bzr+ssh:
Running juju-deployer -v -c /tmp/tmpQUsGpn/
Tests running...
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
Ubuntu CI Bot (uci-bot) wrote : | # |
The attempt to merge lp:~cprov/uci-engine/tr-nova-failures into lp:uci-engine failed. Below is the output from the failed tests.
Checking juju status
Private PPAs: disabled
Preparing local branch upload...
Uploading local branch, fingerprint 1a408df5ab0bf9b
Installing keys from bzr+ssh:
Running juju-deployer -v -c /tmp/tmpWWqzt5/
Tests running...
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
Ubuntu CI Bot (uci-bot) wrote : | # |
The attempt to merge lp:~cprov/uci-engine/tr-nova-failures into lp:uci-engine failed. Below is the output from the failed tests.
Checking juju status
Private PPAs: disabled
Preparing local branch upload...
Uploading local branch, fingerprint 7e2f70c4b12cb12
Installing keys from bzr+ssh:
Running juju-deployer -v -c /tmp/tmpg399TJ/
Tests running...
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
Ubuntu CI Bot (uci-bot) wrote : | # |
The attempt to merge lp:~cprov/uci-engine/tr-nova-failures into lp:uci-engine failed. Below is the output from the failed tests.
2015-01-09 00:21:39 INFO juju.cmd supercommand.go:37 running jujud [1.20.14.
2015-01-09 00:21:39 DEBUG juju.agent agent.go:377 read agent config, format "1.18"
2015-01-09 00:21:39 INFO juju.jujud unit.go:78 unit agent unit-ci-
2015-01-09 00:21:39 INFO juju.worker runner.go:260 start "api"
2015-01-09 00:21:39 INFO juju.state.api apiclient.go:242 dialing "wss://
2015-01-09 00:21:39 INFO juju.state.api apiclient.go:176 connection established to "wss://
2015-01-09 00:21:39 INFO juju.state.api apiclient.go:242 dialing "wss://
2015-01-09 00:21:39 INFO juju.state.api apiclient.go:176 connection established to "wss://
2015-01-09 00:21:46 INFO juju.state.api apiclient.go:242 dialing "wss://
2015-01-09 00:21:46 INFO juju.state.api apiclient.go:176 connection established to "wss://
2015-01-09 00:21:46 INFO juju.worker runner.go:260 start "upgrader"
2015-01-09 00:21:46 INFO juju.worker runner.go:260 start "logger"
2015-01-09 00:21:46 DEBUG juju.worker.logger logger.go:35 initial log config: "<root>=DEBUG"
2015-01-09 00:21:46 INFO juju.worker runner.go:260 start "uniter"
2015-01-09 00:21:46 DEBUG juju.worker.logger logger.go:60 logger setup
2015-01-09 00:21:46 INFO juju.worker runner.go:260 start "apiaddressupdater"
2015-01-09 00:21:46 INFO juju.worker runner.go:260 start "rsyslog"
2015-01-09 00:21:46 DEBUG juju.worker.rsyslog worker.go:75 starting rsyslog worker mode 1 for "unit-ci-
2015-01-09 00:21:46 DEBUG juju.worker.logger logger.go:45 reconfiguring logging from "<root>=DEBUG" to "<root>
2015-01-09 00:22:18 INFO juju-log Making dir /srv/ci-
2015-01-09 00:22:19 INFO juju-log Adding dependencies.
2015-01-09 00:22:19 INFO juju-log installing apt packages...
2015-01-09 00:22:30 INFO config-changed gpg: keyring `/tmp/tmpf7smlF
2015-01-09 00:22:30 INFO config-changed gpg: keyring `/tmp/tmpf7smlF
2015-01-09 00:22:30 INFO config-changed gpg: requesting key 6A8DFC40 from hkp server keyserver.
2015-01-09 00:22:30 INFO config-changed gpg: /tmp/tmpf7smlF/
2015-01-09 00:22:30 INFO config-changed gpg: key 6A8DFC40: public key "Launchpad PPA for Canonical CI Engineering" imported
2015-01-09 00:22:30 INFO config-changed gpg: Total number processed: 1
2015-01-09 00:22:30 INFO config-changed gpg: imported: 1 (RSA: 1)
2015-01-09 00:22:31 INFO config-changed OK
2015-01-09 00:22:33 INFO config-changed Hit http://
2015-01-09 00:22:33 INFO config-changed Get:1 http://
2015-01-09 00:22:33 INFO config-changed Get:2 http://
2015-01-09 00:22:33 INFO config-changed Get:3 http://
Ubuntu CI Bot (uci-bot) wrote : | # |
The attempt to merge lp:~cprov/uci-engine/tr-nova-failures into lp:uci-engine failed. Below is the output from the failed tests.
2015-01-09 01:04:22 INFO juju.cmd supercommand.go:37 running jujud [1.20.14.
2015-01-09 01:04:22 DEBUG juju.agent agent.go:377 read agent config, format "1.18"
2015-01-09 01:04:22 INFO juju.jujud unit.go:78 unit agent unit-ci-
2015-01-09 01:04:22 INFO juju.worker runner.go:260 start "api"
2015-01-09 01:04:22 INFO juju.state.api apiclient.go:242 dialing "wss://
2015-01-09 01:04:22 INFO juju.state.api apiclient.go:176 connection established to "wss://
2015-01-09 01:04:22 INFO juju.state.api apiclient.go:242 dialing "wss://
2015-01-09 01:04:22 INFO juju.state.api apiclient.go:176 connection established to "wss://
2015-01-09 01:04:23 INFO juju.state.api apiclient.go:242 dialing "wss://
2015-01-09 01:04:23 INFO juju.state.api apiclient.go:176 connection established to "wss://
2015-01-09 01:04:23 INFO juju.worker runner.go:260 start "upgrader"
2015-01-09 01:04:23 INFO juju.worker runner.go:260 start "logger"
2015-01-09 01:04:23 DEBUG juju.worker.logger logger.go:35 initial log config: "<root>=DEBUG"
2015-01-09 01:04:23 INFO juju.worker runner.go:260 start "uniter"
2015-01-09 01:04:23 DEBUG juju.worker.logger logger.go:60 logger setup
2015-01-09 01:04:23 INFO juju.worker runner.go:260 start "apiaddressupdater"
2015-01-09 01:04:23 INFO juju.worker runner.go:260 start "rsyslog"
2015-01-09 01:04:23 DEBUG juju.worker.rsyslog worker.go:75 starting rsyslog worker mode 1 for "unit-ci-
2015-01-09 01:04:23 DEBUG juju.worker.logger logger.go:45 reconfiguring logging from "<root>=DEBUG" to "<root>
2015-01-09 01:04:42 INFO juju-log Making dir /srv/ci-
2015-01-09 01:04:45 INFO juju-log Adding dependencies.
2015-01-09 01:04:45 INFO juju-log installing apt packages...
2015-01-09 01:04:48 INFO config-changed gpg: keyring `/tmp/tmp5SORt5
2015-01-09 01:04:48 INFO config-changed gpg: keyring `/tmp/tmp5SORt5
2015-01-09 01:04:48 INFO config-changed gpg: requesting key 6A8DFC40 from hkp server keyserver.
2015-01-09 01:04:48 INFO config-changed gpg: /tmp/tmp5SORt5/
2015-01-09 01:04:48 INFO config-changed gpg: key 6A8DFC40: public key "Launchpad PPA for Canonical CI Engineering" imported
2015-01-09 01:04:48 INFO config-changed gpg: Total number processed: 1
2015-01-09 01:04:48 INFO config-changed gpg: imported: 1 (RSA: 1)
2015-01-09 01:04:50 INFO config-changed OK
2015-01-09 01:04:57 INFO config-changed Get:1 http://
2015-01-09 01:04:57 INFO config-changed Hit http://
2015-01-09 01:04:57 INFO config-changed Get:2 http://
2015-01-09 01:04:57 INFO config-changed Get:3 http://
2015-01-09...
Ubuntu CI Bot (uci-bot) wrote : | # |
The attempt to merge lp:~cprov/uci-engine/tr-nova-failures into lp:uci-engine failed. Below is the output from the failed tests.
Checking juju status
Private PPAs: disabled
Preparing local branch upload...
Uploading local branch, fingerprint 12dab6d744110a9
Installing keys from bzr+ssh:
Running juju-deployer -v -c /tmp/tmpCoeq2G/
Tests running...
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
Vincent Ladeuil (vila) wrote : | # |
Silently disabling tests is making us blind: the failures do happen and we need to know about them.
Ubuntu CI Bot (uci-bot) wrote : | # |
The attempt to merge lp:~cprov/uci-engine/tr-nova-failures into lp:uci-engine failed. Below is the output from the failed tests.
Checking juju status
Private PPAs: disabled
Preparing local branch upload...
Uploading local branch, fingerprint bff593fda1bf4c0
Installing keys from bzr+ssh:
Running juju-deployer -v -c /tmp/tmpt14Ge4/
Tests running...
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
Celso Providelo (cprov) wrote : | # |
Vicent,
Skipping a test is not necessarily blindly ignoring the problem, it's a documented way to move forward and not block everyone else.
That said, we still have few hours to get this properly fixed ... let's work.
Ubuntu CI Bot (uci-bot) wrote : | # |
The attempt to merge lp:~cprov/uci-engine/tr-nova-failures into lp:uci-engine failed. Below is the output from the failed tests.
Checking juju status
Private PPAs: disabled
Preparing local branch upload...
Uploading local branch, fingerprint c8d524020e06218
Installing keys from bzr+ssh:
Running juju-deployer -v -c /tmp/tmpm1wNZl/
Tests running...
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
ci-utils.
Ursula Junque (ursinha) wrote : | # |
Test failures are valid, not just tarmac hiccups (as I supposed). Celso has a branch to fix that that needs to be merged into this one once it hits trunk (MP: https:/
Ursula Junque (ursinha) wrote : | # |
I managed to comment in the wrong MP, need more coffee.
- 925. By Celso Providelo
-
revert webui tests to the default sst timeout (10s), issue has been fixed in another MP.
- 926. By Celso Providelo
-
Add appropriate tarmac-bootstack nova flavour.
- 927. By Celso Providelo
-
Moving tarmac-bootstack flavor up in the config list, so it gets higher precedence than 'small' ones.
- 928. By Celso Providelo
-
merge trunk
Preview Diff
1 | === modified file 'ci-utils/ci_utils/testing/features.py' |
2 | --- ci-utils/ci_utils/testing/features.py 2014-11-26 08:09:56 +0000 |
3 | +++ ci-utils/ci_utils/testing/features.py 2015-01-09 15:16:15 +0000 |
4 | @@ -36,10 +36,6 @@ |
5 | class Swift(features.Feature): |
6 | |
7 | def _probe(self): |
8 | - # FIXME: swift needs to handle more transient failures, tests are |
9 | - # currently failing when swift becomes too slow. Disable all tests that |
10 | - # require a "perfect" swift -- vila 2014-11-26 |
11 | - return False |
12 | conn = self.get_connection() |
13 | if conn is None: |
14 | return False |
15 | @@ -71,10 +67,6 @@ |
16 | class NovaCompute(features.Feature): |
17 | |
18 | def _probe(self): |
19 | - # FIXME: nova needs to handle more transient failures, tests are |
20 | - # currently failing for various known reasons. Disable all tests that |
21 | - # require a "perfect" nova. -- vila 2014-11-26 |
22 | - return False |
23 | client = self.get_client() |
24 | if client is None: |
25 | return False |
26 | @@ -130,6 +122,9 @@ |
27 | nova_creds = NovaCredentials() |
28 | |
29 | |
30 | +autopkgtest = features.ExecutableFeature('adt-run') |
31 | + |
32 | + |
33 | class BootstrappedJuju(features.Feature): |
34 | |
35 | def __init__(self): |
36 | |
37 | === modified file 'juju-deployer/configs/unit_config.yaml.tmpl' |
38 | --- juju-deployer/configs/unit_config.yaml.tmpl 2014-11-05 05:20:40 +0000 |
39 | +++ juju-deployer/configs/unit_config.yaml.tmpl 2015-01-09 15:16:15 +0000 |
40 | @@ -48,6 +48,7 @@ |
41 | master_ppa: $CI_MASTER_PPA |
42 | tr_flavors: |
43 | - m1.smaller |
44 | + - m1.smaller.production |
45 | - m1.small |
46 | - standard.small |
47 | |
48 | |
49 | === modified file 'test_runner/tstrun/tests/test_run_test.py' |
50 | --- test_runner/tstrun/tests/test_run_test.py 2014-10-17 03:00:39 +0000 |
51 | +++ test_runner/tstrun/tests/test_run_test.py 2015-01-09 15:16:15 +0000 |
52 | @@ -78,7 +78,7 @@ |
53 | res.stopTestRun() |
54 | return res |
55 | |
56 | - def test_passs(self): |
57 | + def test_pass(self): |
58 | res = self.fake_result_for_dep8_test('PASS', 'xx') |
59 | self.assertTrue(res.wasSuccessful()) |
60 | self.assertEqual(0, len(res.errors)) |
61 | |
62 | === modified file 'test_runner/tstrun/tests/test_worker.py' |
63 | --- test_runner/tstrun/tests/test_worker.py 2015-01-07 14:15:55 +0000 |
64 | +++ test_runner/tstrun/tests/test_worker.py 2015-01-09 15:16:15 +0000 |
65 | @@ -44,6 +44,7 @@ |
66 | load_tests = scenarii.load_tests_with_scenarios |
67 | |
68 | |
69 | +@features.requires(features.autopkgtest) |
70 | @features.requires(features.nova_creds) |
71 | @features.requires(features.nova_compute) |
72 | class TestWorkerHandleRequest(unittest.TestCase): |
73 | @@ -133,6 +134,7 @@ |
74 | self.assertEqual(amqp_utils.progress_completed, retcode) |
75 | |
76 | |
77 | +@features.requires(features.autopkgtest) |
78 | @features.requires(features.nova_creds) |
79 | @features.requires(features.nova_compute) |
80 | class TestWorkerHandleRequestFor(unittest.TestCase): |
81 | |
82 | === modified file 'testing/run_tests.py' |
83 | --- testing/run_tests.py 2015-01-06 03:29:49 +0000 |
84 | +++ testing/run_tests.py 2015-01-09 15:16:15 +0000 |
85 | @@ -390,7 +390,7 @@ |
86 | super(RunTestsArgParser, self).__init__('run-tests') |
87 | self.add_argument( |
88 | '--no-skip', action='store_true', |
89 | - dest='no_skip', |
90 | + dest='no_skip', default=False, |
91 | help='Errors if at lest one test is skipped.') |
92 | |
93 |
Good work, thanks for digging into this !
Swift needs to be re-activated too and I have a few comments inline.