Code review comment for lp:~cprov/uci-engine/1335753-glance-creds

Revision history for this message
Vincent Ladeuil (vila) wrote :

Typos aside, there is an issue with tests creating and removing unit_config at the root of the branch.

With a full deployment available on hp and GLANCE_* vars defined, I get:

$ ./run-tests
<...>

======================================================================
ERROR: tests.test_test_runner.TestTestRunner.test_process_ticket
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/test_test_runner.py", line 90, in test_process_ticket
    raise_errors=True)
  File "/home/vila/ci/uci-engine/reviews/1335753-glance-creds/ci-utils/ci_utils/amqp_utils.py", line 99, in send
    conn, channel = declare_queue(queue_name, config)
  File "/home/vila/ci/uci-engine/reviews/1335753-glance-creds/ci-utils/ci_utils/amqp_utils.py", line 83, in declare_queue
    raise e
error: [Errno 110] Connection timed out
======================================================================
FAIL: juju-deployer.test_deploy.TestCheckEnvironment.test_check_environment_defaults
----------------------------------------------------------------------
Traceback (most recent call last):
  File "build/bdist.linux-x86_64/egg/mock.py", line 1201, in patched
    return func(*args, **keywargs)
  File "juju-deployer/test_deploy.py", line 77, in test_check_environment_defaults
    self.assertEqual('', os.environ['GLANCE_OS_USERNAME'])
  File "/usr/lib/python2.7/unittest/case.py", line 515, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/usr/lib/python2.7/unittest/case.py", line 508, in _baseAssertEqual
    raise self.failureException(msg)
AssertionError: '' != '<email address hidden>'

Ran 594 tests in 501.909s
FAILED (failures=2)

test_process_tickey is now understood as missing an exposed rabbit.

But re-running:
$ ./run-tests
<...>
======================================================================
ERROR: test_runner.tstrun.tests.test_data_store.TestDataStore.test_put_file_stores_content
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_runner/tstrun/tests/test_data_store.py", line 62, in setUp
    tstrun.get_auth_config(), public=True)
  File "test_runner/tstrun/__init__.py", line 28, in get_auth_config
    with open(path) as f:
IOError: [Errno 2] No such file or directory: '/home/vila/ci/uci-engine/reviews/1335753-glance-creds/unit_config'
======================================================================
ERROR: test_runner.tstrun.tests.test_data_store.TestDataStore.test_store_created_empty
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_runner/tstrun/tests/test_data_store.py", line 62, in setUp
    tstrun.get_auth_config(), public=True)
  File "test_runner/tstrun/__init__.py", line 28, in get_auth_config
    with open(path) as f:
IOError: [Errno 2] No such file or directory: '/home/vila/ci/uci-engine/reviews/1335753-glance-creds/unit_config'
======================================================================
ERROR: test_runner.tstrun.tests.test_testbed.TestTestbed.test_create_new_ssh_key
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_runner/tstrun/tests/test_testbed.py", line 48, in setUp
    self.tb_name, tstrun.get_auth_config())
  File "test_runner/tstrun/__init__.py", line 28, in get_auth_config
    with open(path) as f:
IOError: [Errno 2] No such file or directory: '/home/vila/ci/uci-engine/reviews/1335753-glance-creds/unit_config'
======================================================================
ERROR: test_runner.tstrun.tests.test_testbed.TestTestbed.test_create_no_image
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_runner/tstrun/tests/test_testbed.py", line 48, in setUp
    self.tb_name, tstrun.get_auth_config())
  File "test_runner/tstrun/__init__.py", line 28, in get_auth_config
    with open(path) as f:
IOError: [Errno 2] No such file or directory: '/home/vila/ci/uci-engine/reviews/1335753-glance-creds/unit_config'
======================================================================
ERROR: test_runner.tstrun.tests.test_testbed.TestTestbed.test_create_unknown
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_runner/tstrun/tests/test_testbed.py", line 48, in setUp
    self.tb_name, tstrun.get_auth_config())
  File "test_runner/tstrun/__init__.py", line 28, in get_auth_config
    with open(path) as f:
IOError: [Errno 2] No such file or directory: '/home/vila/ci/uci-engine/reviews/1335753-glance-creds/unit_config'
======================================================================
ERROR: test_runner.tstrun.tests.test_testbed.TestTestbed.test_create_usable_testbed
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_runner/tstrun/tests/test_testbed.py", line 48, in setUp
    self.tb_name, tstrun.get_auth_config())
  File "test_runner/tstrun/__init__.py", line 28, in get_auth_config
    with open(path) as f:
IOError: [Errno 2] No such file or directory: '/home/vila/ci/uci-engine/reviews/1335753-glance-creds/unit_config'
======================================================================
ERROR: test_runner.tstrun.tests.test_testbed.TestTestbed.test_existing_home_ssh
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_runner/tstrun/tests/test_testbed.py", line 48, in setUp
    self.tb_name, tstrun.get_auth_config())
  File "test_runner/tstrun/__init__.py", line 28, in get_auth_config
    with open(path) as f:
IOError: [Errno 2] No such file or directory: '/home/vila/ci/uci-engine/reviews/1335753-glance-creds/unit_config'
======================================================================
FAIL: ci-utils.ci_utils.tests.test_unit_config.TestUnitConfig.test_asserts_exists
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vila/ci/uci-engine/reviews/1335753-glance-creds/ci-utils/ci_utils/tests/test_unit_config.py", line 41, in test_asserts_exists
    get_auth_config()
  File "/usr/lib/python2.7/unittest/case.py", line 116, in __exit__
    "{0} not raised".format(exc_name))
AssertionError: AssertionError not raised
======================================================================
FAIL: test_runner.tstrun.tests.test_worker.TestWorkerHandleRequest.test_handle_request_precise_image
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_runner/tstrun/tests/test_worker.py", line 78, in test_handle_request_precise_image
    self.assertTestRun(params)
  File "test_runner/tstrun/tests/test_worker.py", line 68, in assertTestRun
    self.data_store.list_files())
  File "/usr/lib/python2.7/unittest/case.py", line 515, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/usr/lib/python2.7/unittest/case.py", line 744, in assertListEqual
    self.assertSequenceEqual(list1, list2, msg, seq_type=list)
  File "/usr/lib/python2.7/unittest/case.py", line 726, in assertSequenceEqual
    self.fail(msg)
  File "/usr/lib/python2.7/unittest/case.py", line 412, in fail
    raise self.failureException(msg)
AssertionError: Lists differ: ['libpng-summary.log', 'libpng... != []

First list contains 4 additional elements.
First extra element 0:
libpng-summary.log

+ []
- ['libpng-summary.log',
- 'libpng.log',
- 'libpng.subunit',
- 'testbed-cloud-init.log']
======================================================================
FAIL: test_runner.tstrun.tests.test_worker.TestWorkerHandleRequest.test_handle_request_saucy_image
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_runner/tstrun/tests/test_worker.py", line 94, in test_handle_request_saucy_image
    self.assertTestRun(params)
  File "test_runner/tstrun/tests/test_worker.py", line 68, in assertTestRun
    self.data_store.list_files())
  File "/usr/lib/python2.7/unittest/case.py", line 515, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/usr/lib/python2.7/unittest/case.py", line 744, in assertListEqual
    self.assertSequenceEqual(list1, list2, msg, seq_type=list)
  File "/usr/lib/python2.7/unittest/case.py", line 726, in assertSequenceEqual
    self.fail(msg)
  File "/usr/lib/python2.7/unittest/case.py", line 412, in fail
    raise self.failureException(msg)
AssertionError: Lists differ: ['libpng-summary.log', 'libpng... != []

First list contains 4 additional elements.
First extra element 0:
libpng-summary.log

+ []
- ['libpng-summary.log',
- 'libpng.log',
- 'libpng.subunit',
- 'testbed-cloud-init.log']
======================================================================
FAIL: juju-deployer.test_deploy.TestCheckEnvironment.test_check_environment_defaults
----------------------------------------------------------------------
Traceback (most recent call last):
  File "build/bdist.linux-x86_64/egg/mock.py", line 1201, in patched
    return func(*args, **keywargs)
  File "juju-deployer/test_deploy.py", line 77, in test_check_environment_defaults
    self.assertEqual('', os.environ['GLANCE_OS_USERNAME'])
  File "/usr/lib/python2.7/unittest/case.py", line 515, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/usr/lib/python2.7/unittest/case.py", line 508, in _baseAssertEqual
    raise self.failureException(msg)
AssertionError: '' != '<email address hidden>'

Ran 594 tests in 269.108s
FAILED (failures=11)

review: Needs Fixing

« Back to merge proposal