Merge lp:~cprov/launchpad/bug-424797-buildd-manager-test-failure into lp:launchpad
Proposed by
Celso Providelo
Status: | Merged |
---|---|
Approved by: | Jonathan Lange |
Approved revision: | no longer in the source branch. |
Merged at revision: | not available |
Proposed branch: | lp:~cprov/launchpad/bug-424797-buildd-manager-test-failure |
Merge into: | lp:launchpad |
Diff against target: | None lines |
To merge this branch: | bzr merge lp:~cprov/launchpad/bug-424797-buildd-manager-test-failure |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jonathan Lange (community) | code | Approve | |
Canonical Launchpad Engineering | Pending | ||
Review via email:
|
To post a comment you must log in.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
reviewer jml
= Summary =
This branch fixes https:/ /bugs.edge. launchpad. net/soyuz/ +bug/424797
As reported in the bug, It was originally caused by a change in sampledata. However it is quite intriguing to see failures like that being 'swallowed' in our test suite.
It turns out that currently any failures/errors on trial.unittest. TestCase are ignored.
{{{ TrialTestCase) :
class TestTrial(
def test_swallowed_ errors( self):
self.assertEqu als(1, 2)
}}}
{{{ testrunner. layer.UnitTests tests: testrunner. layer.UnitTests in 0.000 seconds. _errors (lp.buildmaster .tests. test_manager. TestTrial)
$ ./bin/test -vv -t TestTrial
Running tests at level 1
Running zope.testing.
Set up zope.testing.
Running:
test_swallowed
Failure in test test_swallowed_ errors (lp.buildmaster .tests. test_manager. TestTrial)
Ran 1 tests with 0 failures and 0 errors in 0.009 seconds. testrunner. layer.UnitTests in 0.000 seconds.
Tearing down left over layers:
Tear down zope.testing.
}}}
This is currently happening in buildbot, so I assume it's not a *karmic* issue.
Ideally I would like to have the specific test fixing (contained in the branch) and the trial-related fixes landed separately, but if it's simple enough I don't mind mixing both.
== Tests ==
/bin/test -vv -t testScanRescues JobFromBrokenBu ilder
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files: buildmaster/ tests/test_ manager. py
lib/lp/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkq kA78ACgkQ7KBXuX yZSjAIPACeOwhX0 /FCWxeYJAgrzf2k jlAq rX/n6q2uV9lotnm 08
qJUAmgMZAEz7WBs
=G72k
-----END PGP SIGNATURE-----