Merge lp:~cprov/core-image-watcher/bump-uservice into lp:core-image-watcher

Proposed by Celso Providelo
Status: Merged
Approved by: Celso Providelo
Approved revision: 17
Merged at revision: 15
Proposed branch: lp:~cprov/core-image-watcher/bump-uservice
Merge into: lp:core-image-watcher
Diff against target: 21 lines (+3/-1)
2 files modified
core_image_watcher/__init__.py (+2/-0)
requirements.txt (+1/-1)
To merge this branch: bzr merge lp:~cprov/core-image-watcher/bump-uservice
Reviewer Review Type Date Requested Status
Celso Providelo (community) Approve
Review via email: mp+255161@code.launchpad.net

Commit message

Upgrading uservices-utils dependency to 1.0.2.1 to benefit of working logstash support.

Description of the change

Upgrading uservices-utils dependency to 1.0.2.1 to benefit of working logstash support.

Also ensure the service logs a watermarked message on start ('Started!') so we can monitor if it is dying unexpectedly.

Project pip-cache already include the new package version.

To post a comment you must log in.
Revision history for this message
Celso Providelo (cprov) :
review: Approve
Revision history for this message
Ubuntu CI Bot (uci-bot) wrote :
Download full text (7.4 KiB)

The attempt to merge lp:~cprov/core-image-watcher/bump-uservice into lp:core-image-watcher failed. Below is the output from the failed tests.

Using base prefix '/usr'
New python executable in /tmp/venv-core-image-watcherdkd9ek2u/bin/python3
Also creating executable in /tmp/venv-core-image-watcherdkd9ek2u/bin/python
Installing setuptools, pip...done.
Running virtualenv with interpreter /usr/bin/python3
Ignoring indexes: https://pypi.python.org/simple/
Downloading/unpacking kombu==3.0.24 (from -r requirements.txt (line 1))
Downloading/unpacking python-logstash==0.4.2 (from -r requirements.txt (line 2))
  Running setup.py (path:/tmp/venv-core-image-watcherdkd9ek2u/build/python-logstash/setup.py) egg_info for package python-logstash

Downloading/unpacking uservice-utils==1.0.2.1 (from -r requirements.txt (line 3))
Downloading/unpacking amqp>=1.4.5,<2.0 (from kombu==3.0.24->-r requirements.txt (line 1))
  Running setup.py (path:/tmp/venv-core-image-watcherdkd9ek2u/build/amqp/setup.py) egg_info for package amqp

Downloading/unpacking anyjson>=0.3.3 (from kombu==3.0.24->-r requirements.txt (line 1))
  Running setup.py (path:/tmp/venv-core-image-watcherdkd9ek2u/build/anyjson/setup.py) egg_info for package anyjson

Installing collected packages: kombu, python-logstash, uservice-utils, amqp, anyjson
  Running setup.py install for python-logstash

  Running setup.py install for amqp

  Running setup.py install for anyjson
    Fixing build/lib/anyjson/__init__.py
    Skipping implicit fixer: buffer
    Skipping implicit fixer: idioms
    Skipping implicit fixer: set_literal
    Skipping implicit fixer: ws_comma
    Fixing build/lib/anyjson/__init__.py
    Skipping implicit fixer: buffer
    Skipping implicit fixer: idioms
    Skipping implicit fixer: set_literal
    Skipping implicit fixer: ws_comma

Successfully installed kombu python-logstash uservice-utils amqp anyjson
Cleaning up...
Downloading/unpacking testtools==1.7.1 (from -r test_requirements.txt (line 1))
Downloading/unpacking flake8==2.4.0 (from -r test_requirements.txt (line 2))
  Downloading flake8-2.4.0-py2.py3-none-any.whl
Downloading/unpacking unittest2>=1.0.0 (from testtools==1.7.1->-r test_requirements.txt (line 1))
Downloading/unpacking traceback2 (from testtools==1.7.1->-r test_requirements.txt (line 1))
  Downloading traceback2-1.4.0-py2.py3-none-any.whl
Downloading/unpacking extras (from testtools==1.7.1->-r test_requirements.txt (line 1))
  Downloading extras-0.0.3.tar.gz
  Running setup.py (path:/tmp/venv-core-image-watcherdkd9ek2u/build/extras/setup.py) egg_info for package extras

Downloading/unpacking python-mimeparse (from testtools==1.7.1->-r test_requirements.txt (line 1))
  Downloading python-mimeparse-0.1.4.tar.gz
  Running setup.py (path:/tmp/venv-core-image-watcherdkd9ek2u/build/python-mimeparse/setup.py) egg_info for package python-mimeparse

Downloading/unpacking pyflakes>=0.8.1,<0.9 (from flake8==2.4.0->-r test_requirements.txt (line 2))
  Downloading pyflakes-0.8.1-py2.py3-none-any.whl
Downloading/unpacking pep8>=1.5.7,<1.6 (from flake8==2.4.0->-r test_requirements.txt (line 2))
  Downloading pep8-1.5.7-py2.py3-none-any.whl
Downloadin...

Read more...

17. By Celso Providelo

Fix testing issue.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'core_image_watcher/__init__.py'
2--- core_image_watcher/__init__.py 2015-04-01 21:26:45 +0000
3+++ core_image_watcher/__init__.py 2015-04-03 02:05:24 +0000
4@@ -150,6 +150,8 @@
5 config['logstash'] if 'logstash' in config else None
6 )
7
8+ logger.info('Started!', extra=logging_extra)
9+
10 amqp_uris = config.get('amqp', 'uris').split()
11 location = config.get('image', 'location')
12 channel = config.get('image', 'channel')
13
14=== modified file 'requirements.txt'
15--- requirements.txt 2015-04-02 04:41:41 +0000
16+++ requirements.txt 2015-04-03 02:05:24 +0000
17@@ -1,3 +1,3 @@
18 kombu==3.0.24
19 python-logstash==0.4.2
20-uservice_utils==1.0.1
21+uservice_utils==1.0.2.1

Subscribers

People subscribed via source and target branches