Merge lp:~cprov/core-image-publisher/flake8 into lp:core-image-publisher

[Celso Providelo]

Installing flake8 for tests and benefiting of its integration with setuptools for processing all installed files.

Installing flake8 for tests and benefiting of its integration with setuptools for processing all installed files.

Also fixing current issues and requiring flake8 clearness in tarmac.

[Thomi Richards (thomir-deactivatedaccount)]

review: Approve

=== modified file 'README.rst'
--- README.rst	2015-03-30 20:42:11 +0000
+++ README.rst	2015-04-01 01:34:02 +0000
@@ -50,6 +50,11 @@
 
   $ python setup.py test
 
+Also with elegance in mind::
+
+  $ python setup.py flake8
+
+
 The config file
 ===============
 

=== modified file 'called-by-tarmac.py'
--- called-by-tarmac.py	2015-03-25 23:21:30 +0000
+++ called-by-tarmac.py	2015-04-01 01:34:02 +0000
@@ -89,6 +89,11 @@
                 'setup.py',
                 'test',
             ],
+            [
+                os.path.join(ve_dir, 'bin', 'python3'),
+                'setup.py',
+                'flake8',
+            ],
         )
         for cmd in all_cmds:
             ret = _run_command(cmd)

=== modified file 'core_image_publisher/constants.py'
--- core_image_publisher/constants.py	2015-03-31 16:45:10 +0000
+++ core_image_publisher/constants.py	2015-04-01 01:34:02 +0000
@@ -25,6 +25,7 @@
 
 SERVICE_NAME = "core-image-publisher"
 
+
 def _get_hostname():
     """Return sanitized contents of /etc/hostname.
 
@@ -32,8 +33,8 @@
     are too big due to our long environment names ('<spec_name>-<MD5>').
     Linux (DNS for RFC1035, really) only supports labels up to 64 chars and
     the fallback varies from tool to tool, `cloud-init` chokes on longer
-    names and sets 'ubuntu', `hostnamectl` (systemd) would truncate the
-    given data. 
+    names and sets 'ubuntu' (which is the value considered by socket.get*),
+    `hostnamectl` (systemd) would truncate the given data.
 
     None of this is ideal to our applications, that's why we will operate
     on the pristine /etc/hostname and remove the 'juju-' and '-machine' terms

=== modified file 'setup.py'
--- setup.py	2015-03-25 21:36:10 +0000
+++ setup.py	2015-04-01 01:34:02 +0000
@@ -20,7 +20,10 @@
 import sys
 assert sys.version_info >= (3,), 'Python 3 is required'
 
-from setuptools import find_packages, setup, Extension
+from setuptools import (
+    find_packages,
+    setup,
+)
 
 
 VERSION = '1.0.0'

=== modified file 'test_requirements.txt'
--- test_requirements.txt	2015-03-25 21:36:10 +0000
+++ test_requirements.txt	2015-04-01 01:34:02 +0000
@@ -1,1 +1,2 @@
-testtools==1.7.1
\ No newline at end of file
+testtools==1.7.1
+flake8==2.4.0