Merge lp:~cprov/core-image-publisher/fake-home into lp:core-image-publisher

[Celso Providelo]

Define a fake/temporary $HOME for our system user (core-worker) for calling u-d-f for downloading images.

Define a fake/temporary $HOME for our system user (core-worker) for calling u-d-f for downloading images. u-d-f fills '~/.cache/ubuntuimages/' with:

{{{
571848 tmpg3m9bclk/core-355-cloud.img
640252 tmpg3m9bclk/core-355.img
4 tmpg3m9bclk/.cache/ubuntuimages/ubuntu-core/devel-proposed/generic_amd64/version-355.tar.xz.asc
4 tmpg3m9bclk/.cache/ubuntuimages/ubuntu-core/devel-proposed/generic_amd64/version-355.tar.xz
12 tmpg3m9bclk/.cache/ubuntuimages/ubuntu-core/devel-proposed/generic_amd64
16 tmpg3m9bclk/.cache/ubuntuimages/ubuntu-core/devel-proposed
20 tmpg3m9bclk/.cache/ubuntuimages/ubuntu-core
4 tmpg3m9bclk/.cache/ubuntuimages/gpg/image-signing.tar.xz
4 tmpg3m9bclk/.cache/ubuntuimages/gpg/image-signing.tar.xz.asc
4 tmpg3m9bclk/.cache/ubuntuimages/gpg/image-master.tar.xz
4 tmpg3m9bclk/.cache/ubuntuimages/gpg/image-master.tar.xz.asc
20 tmpg3m9bclk/.cache/ubuntuimages/gpg
43640 tmpg3m9bclk/.cache/ubuntuimages/pool/ubuntu-cc040b86eeac036f2e4d2762ed4dc39e37806befc0d625ce6209c46cbb373b80.tar.xz
4 tmpg3m9bclk/.cache/ubuntuimages/pool/ubuntu-cc040b86eeac036f2e4d2762ed4dc39e37806befc0d625ce6209c46cbb373b80.tar.xz.asc
4 tmpg3m9bclk/.cache/ubuntuimages/pool/device-b7114519bc4b23bd78c051957d382014f7938a906c38a96d3c1b12b3470ea6e2.tar.xz.asc
76792 tmpg3m9bclk/.cache/ubuntuimages/pool/device-b7114519bc4b23bd78c051957d382014f7938a906c38a96d3c1b12b3470ea6e2.tar.xz
120444 tmpg3m9bclk/.cache/ubuntuimages/pool
120488 tmpg3m9bclk/.cache/ubuntuimages
120492 tmpg3m9bclk/.cache
1332596 tmpg3m9bclk/
}}}

For now we can throw it away since bandwidth is cheap inside the DC, but maybe we can explore this already present caching mechanism for operation with hot-cache workers on other image tests.

Since we do have short-living workers, development would have to slow down a lot before we can see any benefit. Also if we don't have any policy for periodically recycling workers, we might have to cleanup its $HOME. Anyway, let's not prematurely optimise

[Francis Ginther (fginther)]

Approve

review: Approve

=== modified file 'core-service.conf'
--- core-service.conf	2015-03-30 06:10:53 +0000
+++ core-service.conf	2015-04-01 03:43:41 +0000
@@ -3,7 +3,7 @@
 uris = amqp://guest:guest@localhost:5672//
 
 [nova]
-os_username = thomi
-os_password = kNRCNawCAT5k
-os_tenant_name = thomi_project
+os_username = foo
+os_password = <redacted>
+os_tenant_name = foo_project
 os_auth_url = http://172.20.161.138:5000/v2.0/

=== modified file 'core_image_publisher/worker.py'
--- core_image_publisher/worker.py	2015-03-31 20:21:41 +0000
+++ core_image_publisher/worker.py	2015-04-01 03:43:41 +0000
@@ -108,6 +108,12 @@
 def download_image(name, channel, device, tmpdir):
     """Download the ubuntu code image, return a path to it on disk."""
     image_path = os.path.join(tmpdir, 'core-{}.img'.format(name))
+    udf_env = {
+        # u-d-f fills '~/.cache/ubuntuimages/' on downloads,
+        # not particulary useful to us, unless we only have one
+        # worker and perform testing retries.
+        'HOME': tmpdir,
+    }
     cmd = ['sudo',
            'ubuntu-device-flash',
            '--revision', name,
@@ -118,7 +124,7 @@
            '-o', image_path,
            '--developer-mode',
            '--cloud']
-    check_call(cmd)
+    check_call(cmd, env=udf_env)
     return image_path