Juju Charms Collection
adt-image-mapper package

Merge lp:~cprov/charms/trusty/adt-image-mapper/basenode-missing-deps into lp:~canonical-ci-engineering/charms/trusty/adt-image-mapper/trunk

  1. Trusty Tahr (14.04)
  2. basenode-missing-deps
  3. Merge into trunk
Proposed by Celso Providelo
Status: Merged
Approved by: Celso Providelo
Approved revision: 7
Merged at revision: 7
Proposed branch: lp:~cprov/charms/trusty/adt-image-mapper/basenode-missing-deps
Merge into: lp:~canonical-ci-engineering/charms/trusty/adt-image-mapper/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
hooks/actions.py (+1/-1)
To merge this branch: bzr merge lp:~cprov/charms/trusty/adt-image-mapper/basenode-missing-deps
Reviewer Review Type Date Requested Status
Paul Larson Approve
Review via email: mp+258693@code.launchpad.net

Commit message

Explicitly installing gcc, because basenode disables 'Recommends:'.

Description of the change

Explicitly installing gcc, because basenode disables 'Recommends:'.

To post a comment you must log in.
Revision history for this message
Paul Larson (pwlars) wrote :

Is gcc enough or do we need build-essential? Otherwise +1

review: Approve
Revision history for this message
Celso Providelo (cprov) wrote :

Paul,

'gcc' was enough in the adt-cloud-worker context -> http://bazaar.launchpad.net/~canonical-ci-engineering/charms/trusty/adt-cloud-worker/trunk/revision/16

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/actions.py'
2--- hooks/actions.py 2015-03-19 16:09:56 +0000
3+++ hooks/actions.py 2015-05-08 21:36:05 +0000
4@@ -12,7 +12,7 @@
5
6
7 REQUIRED_PACKAGES = [
8- 'python-virtualenv', 'python3-dev', 'libssl-dev', 'libffi-dev',
9+ 'python-virtualenv', 'python3-dev', 'gcc', 'libssl-dev', 'libffi-dev',
10 ]
11
12 config = hookenv.config()

Subscribers

People subscribed via source and target branches