Code review comment for lp:~cprofitt/ubuntu-desktop-accomplishments/multimedia-added-music

Revision history for this message
Charles Profitt (cprofitt) wrote :


Thanks... I will make sure to check those better. I think I added the depends when I had two steps and removed it w/o testing again.

---- "Rafal Cieślak" <email address hidden> wrote:
> Review: Approve
> Thanks for your awesome work, Charles!
> I have spotted some problems with your accomplishments, which caused them not to display in the viewer (have you actually tested them?). However, they were very simple, so I fixed them for you.
> First thing was that your new accomplishment depended on itself - which made it always locked. Second - there was missing 'collection = ubuntu-desktop', and the category was incorrect, I changed it to 'category = Multimedia'. Also - the script file was not marked as executable.
> Anyway, I am merging, that's a nice accomplishment, and thanks for fixing the added-music script! ;-)
> --
> You are the owner of lp:~cprofitt/ubuntu-desktop-accomplishments/multimedia-added-music.

« Back to merge proposal