Code review comment for lp:~cprofitt/ubuntu-desktop-accomplishments/multimedia-added-music

Revision history for this message
Rafał Cieślak (rafalcieslak256) wrote :

Thanks for your awesome work, Charles!
I have spotted some problems with your accomplishments, which caused them not to display in the viewer (have you actually tested them?). However, they were very simple, so I fixed them for you.
First thing was that your new accomplishment depended on itself - which made it always locked. Second - there was missing 'collection = ubuntu-desktop', and the category was incorrect, I changed it to 'category = Multimedia'. Also - the script file was not marked as executable.
Anyway, I am merging, that's a nice accomplishment, and thanks for fixing the added-music script! ;-)

review: Approve

« Back to merge proposal