Merge ~cpete/ubuntu-manual-tests:cpete/update-amd64-netboot-tests into ubuntu-manual-tests:main
Status: | Merged |
---|---|
Merged at revision: | cd09db355a484b0f35e393cff2b944c636a7af59 |
Proposed branch: | ~cpete/ubuntu-manual-tests:cpete/update-amd64-netboot-tests |
Merge into: | ubuntu-manual-tests:main |
Diff against target: |
282 lines (+141/-80) 3 files modified
dev/null (+0/-80) testcases/image/1734_PXE UEFI Netboot (Server live) (+71/-0) testcases/image/1759_PXE BIOS Netboot (Server live) (+70/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Steve Langasek | Approve | ||
Review via email: mp+453468@code.launchpad.net |
Description of the change
These changes update the amd64 pxe netboot tests, for both UEFI and BIOS. I have re-written the instructions to direct the tester to only download the netboot artifacts, which should be now be included in the Ubuntu Server Subiquity product on the iso tracker. (At least for amd64)
Additionally, I have removed references to apache, configuring autoinstall, and downloading the ISO. The netboot artifacts are always generated with the ISO build, and the bootloader configurations provided contain the URL to the respective ISO hosted on cdimage (the same url in the test download information). This means the test machine will download the correct iso directly without the user having to set up apache and serve it themselves. This also means we lose out on the simplicity of autoinstall, but I think the overall simplification of the test case is well worth it.
Lastly, I have changed the names of the test files (but not the test case numbers) to be uniform with the other Ubuntu Server Subiquity amd64 testcases. This may require remapping these tests in the isotracker.
Looks good, but there are a few things that should be adjusted before landing this. Inline comments apply to both test cases for the most part