Merge lp:~costamagnagianfranco/ubuntu-archive-tools/sync into lp:ubuntu-archive-tools
Status: | Rejected |
---|---|
Rejected by: | Steve Langasek |
Proposed branch: | lp:~costamagnagianfranco/ubuntu-archive-tools/sync |
Merge into: | lp:ubuntu-archive-tools |
Diff against target: |
40 lines (+7/-4) 1 file modified
auto-sync (+7/-4) |
To merge this branch: | bzr merge lp:~costamagnagianfranco/ubuntu-archive-tools/sync |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Steve Langasek | Disapprove | ||
Review via email: mp+374390@code.launchpad.net |
Description of the change
example of log file:
$ ./auto-sync --dry-run --batch
Reading Ubuntu sources ...
Reading Debian sources ...
Getting differences between Debian/sid and Ubuntu/
[Updating] binutils-mipsen (2~c2 [Ubuntu] < 2~c3 [Debian])
* Trying to add binutils-mipsen ...
binutils-
Previous publication for dateutils with version: 0.4.5-1 found in Ubuntu. Not syncing version: 0.4.5-1 from Debian
[Updating] dictem (1.0.4-2 [Ubuntu] < 1.0.4-4 [Debian])
* Trying to add dictem ...
I: dictem -> dictem_1.0.4-2.
Previous publication for hidrd with version: 0.2.0-12 found in Ubuntu. Not syncing version: 0.2.0-12 from Debian
Previous publication for osmo-hlr with version: 0.2.1-4 found in Ubuntu. Not syncing version: 0.2.1-4 from Debian
Previous publication for pgpdump with version: 0.33-1ubuntu1 found in Ubuntu. Not syncing version: 0.33-1 from Debian
Previous publication for php-horde-icalendar with version: 2.1.8-1 found in Ubuntu. Not syncing version: 2.1.8-1 from Debian
Previous publication for php-horde-image with version: 2.5.3-1 found in Ubuntu. Not syncing version: 2.5.3-1 from Debian
[Updating] quotatool (1:1.4.12-2build1 [Ubuntu] < 1:1.6.2-5 [Debian])
* Trying to add quotatool ...
I: quotatool -> quotatool_
Previous publication for stgit with version: 0.18-1 found in Ubuntu. Not syncing version: 0.18-1 from Debian
[Updating] sysvbanner (1.0.15build1 [Ubuntu] < 1:1.0-16 [Debian])
* Trying to add sysvbanner ...
I: sysvbanner -> sysvbanner_
Previous publication for v-sim with version: 3.7.2-6 found in Ubuntu. Not syncing version: 3.7.2-6 from Debian
Previous publication for vnstat with version: 1.18-2 found in Ubuntu. Not syncing version: 1.18-2 from Debian
[New] ayatana-
No previous publications in Ubuntu
OK (Y/n)? y
* Trying to add ayatana-
ayatana-
[New] baloo-widgets_
Previous publications in Ubuntu:
4:15.12.3-0ubuntu1 (yakkety): Deleted (removed by Steve Langasek: (From Debian) ROM; dead upstream, no more used; Debian bug #829290)
4:15.12.3-0ubuntu1 (xenial): Published
4:15.12.3-0ubuntu1 (xenial): Deleted (removed by Ubuntu Archive Robot: moved to release)
4:15.12.1-0ubuntu1 (xenial): Superseded
4:15.12.1-0ubuntu1 (xenial): Deleted (removed by Ubuntu Archive Robot: moved to release)
4:15.08.2-0ubuntu1 (xenial): Superseded
4:15.08.2-0ubuntu1 (wily): Obsolete
4:15.08.2-0ubuntu1 (wily): Deleted (removed by Ubuntu Archive Robot: moved to release)
4:15.08.1-0ubuntu1 (wily): Superseded
4:15.08.1-0ubuntu1 (wily): Deleted (removed by Ubuntu Archive Robot: moved to release)
... plus 30 more; see https:/
OK (Y/n)? y
* Trying to add baloo-widgets ...
baloo-widgets_
[New] compiz-
Previous publications in Ubuntu:
0.9.7.
0.9.7.
0.9.7.
0.9.7.
0.9.7.
0.9.7.
0.9.7.
0.9.7.
0.9.7.
0.9.5.94-0ubuntu1 (precise): Superseded
... plus 7 more; see https:/
OK (Y/n)? y
* Trying to add compiz-
compiz-
[New] compiz-
Previous publications in Ubuntu:
1:0.9.
1:0.9.
1:0.9.
1:0.9.
1:0.9.
1:0.9.
1:0.9.
1:0.9.
1:0.9.
1:0.9.
... plus 31 more; see https:/
OK (Y/n)? y
* Trying to add compiz-plugins-main ...
compiz-
[New] gcc-8-doc_8.3.0-1
No previous publications in Ubuntu
OK (Y/n)? y
* Trying to add gcc-8-doc ...
gcc-8-doc_8.3.0-1 is trying to override modified binary gcc-8-doc_
[New] google-
No previous publications in Ubuntu
OK (Y/n)? y
* Trying to add google-
google-
[New] libcompizconfig
Previous publications in Ubuntu:
0.9.7.
0.9.7.
0.9.7.
0.9.7.
0.9.7.
0.9.7.
0.9.7.
0.9.7.
0.9.5.94-0ubuntu2 (precise): Superseded
0.9.5.94-0ubuntu2 (oneiric): Obsolete
... plus 72 more; see https:/
OK (Y/n)? y
* Trying to add libcompizconfig ...
libcompizconfig
Out-of-date BUT modified: 379 (52.28%)
Updated: 3 (0.41%)
Ubuntu Specific: 0 (0.00%)
Up-to-date [Modified]: 0 (0.00%)
Up-to-date: 0 (0.00%)
Blacklisted: 111 (15.31%)
Total: 725
Updating: dictem quotatool sysvbanner
Not copying packages in dry-run mode.
Unmerged revisions
- 1343. By Gianfranco Costamagna
-
modify auto-sync script to not sync if the same version has been published also in a previous Ubuntu version, not only the current devel one
Sorry for taking so long to review this; I looked at it briefly when it was first raised but it took some time to think through the subtleties.
I think we should NOT merge this, for a subtle reason. We currently use the extra-removals.txt in the sync-blacklist repository to document packages whose sources have been removed because they *depend on* packages that have been removed for bugginess, rather than because they are buggy themselves.
Without this change, those packages will be re-synced automatically during the next release. With this change, they will not.
Given the tradeoff between missing some of these packages which have become un-buggy and failing to resync them in the next series, and archive admins having to re-remove them in the next series if they are still broken, I think it is better to do the extra work to re-remove them, because it is worse to miss a non-buggy package in a release (or to have its re-syncing delayed, possibly causing knock-on effects) than it is to miss removing a still-unreleasable package from -proposed.
I looked at this MP briefly when it was first raised. I'm generally ok with it, but the rationale is very subtle and I think it needs to be called out here, either in a code comment or at minimum in the commit message.
Specifically, the reason it is correct to not re-sync a source package version that was previously synced and then removed is that we have an unwritten policy of only removing source packages from -proposed if that version of that package is buggy in both Debian and Ubuntu and requires sourceful changes to that package in order to be