Merge lp:~costales/anoise/man-middle into lp:anoise

Proposed by costales on 2017-06-14
Status: Merged
Approved by: costales on 2017-06-14
Approved revision: 56
Merged at revision: 54
Proposed branch: lp:~costales/anoise/man-middle
Merge into: lp:anoise
Diff against target: 128 lines (+10/-26)
7 files modified
anoise/anoise.py (+1/-1)
anoise/preferences.py (+3/-3)
anoise/preferences.ui (+1/-17)
anoise/utils.py (+1/-1)
debian/changelog (+1/-1)
debian/control (+1/-1)
setup.py (+2/-2)
To merge this branch: bzr merge lp:~costales/anoise/man-middle
Reviewer Review Type Date Requested Status
costales Pending
Review via email: mp+325684@code.launchpad.net

Description of the Change

Migrated os.system to subprocess

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'anoise/anoise.py'
2--- anoise/anoise.py 2017-06-12 20:36:07 +0000
3+++ anoise/anoise.py 2017-06-14 18:26:29 +0000
4@@ -1,5 +1,5 @@
5 # -*- coding: utf-8 -*-
6-# ANoise 0.0.27 (Ambient Noise)
7+# ANoise 0.0.28 (Ambient Noise)
8 # Copyright (C) 2015 Marcos Alvarez Costales https://launchpad.net/~costales
9 #
10 # ANoise is free software; you can redistribute it and/or modify
11
12=== modified file 'anoise/preferences.py'
13--- anoise/preferences.py 2017-06-12 20:36:07 +0000
14+++ anoise/preferences.py 2017-06-14 18:26:29 +0000
15@@ -1,5 +1,5 @@
16 # -*- coding: utf-8 -*-
17-# ANoise 0.0.27 (Ambient Noise)
18+# ANoise 0.0.28 (Ambient Noise)
19 # Copyright (C) 2015 Marcos Alvarez Costales https://launchpad.net/~costales
20 #
21 # ANoise is free software; you can redistribute it and/or modify
22@@ -16,7 +16,7 @@
23 # along with ANoise; if not, see http://www.gnu.org/licenses
24 # for more information.
25
26-import gi, os, shutil, webbrowser
27+import gi, os, shutil, webbrowser, subprocess
28 from datetime import datetime, timedelta
29 gi.require_version('Gtk', '3.0')
30 gi.require_version('WebKit', '3.0')
31@@ -118,7 +118,7 @@
32 def _on_navigation_requested(self, view, frame, req):
33 uri = req.get_uri()
34 if uri and uri.startswith('apt'): # OS installer
35- os.system('apturl %s &' % uri)
36+ subprocess.Popen(["apturl", uri], shell=False)
37 if uri and uri.startswith('http'): # authors
38 webbrowser.open(uri)
39 return True
40
41=== modified file 'anoise/preferences.ui'
42--- anoise/preferences.ui 2015-04-27 17:32:53 +0000
43+++ anoise/preferences.ui 2017-06-14 18:26:29 +0000
44@@ -1,5 +1,5 @@
45 <?xml version="1.0" encoding="UTF-8"?>
46-<!-- Generated with glade 3.16.1 -->
47+<!-- Generated with glade 3.18.3 -->
48 <interface domain="anoise">
49 <requires lib="gtk+" version="3.4"/>
50 <object class="GtkAdjustment" id="adjustment_timer">
51@@ -238,22 +238,6 @@
52 <property name="can_focus">False</property>
53 <property name="margin_top">18</property>
54 <child>
55- <object class="GtkLinkButton" id="url_donate">
56- <property name="label" translatable="yes">Donate?</property>
57- <property name="visible">True</property>
58- <property name="can_focus">True</property>
59- <property name="receives_default">True</property>
60- <property name="tooltip_text" translatable="yes">Thanks in advance!</property>
61- <property name="relief">none</property>
62- <property name="uri">http://gufw.org/donate_anoise</property>
63- </object>
64- <packing>
65- <property name="expand">False</property>
66- <property name="fill">False</property>
67- <property name="position">0</property>
68- </packing>
69- </child>
70- <child>
71 <object class="GtkAspectFrame" id="aspectframe1">
72 <property name="visible">True</property>
73 <property name="can_focus">False</property>
74
75=== modified file 'anoise/utils.py'
76--- anoise/utils.py 2017-06-12 20:36:07 +0000
77+++ anoise/utils.py 2017-06-14 18:26:29 +0000
78@@ -1,5 +1,5 @@
79 # -*- coding: utf-8 -*-
80-# ANoise 0.0.27 (Ambient Noise)
81+# ANoise 0.0.28 (Ambient Noise)
82 # Copyright (C) 2015 Marcos Alvarez Costales https://launchpad.net/~costales
83 #
84 # ANoise is free software; you can redistribute it and/or modify
85
86=== modified file 'debian/changelog'
87--- debian/changelog 2017-06-12 20:51:03 +0000
88+++ debian/changelog 2017-06-14 18:26:29 +0000
89@@ -1,4 +1,4 @@
90-anoise (0.0.27) xenial; urgency=low
91+anoise (0.0.28) xenial; urgency=low
92
93 * Fixed sound menu control
94
95
96=== modified file 'debian/control'
97--- debian/control 2017-06-12 20:36:07 +0000
98+++ debian/control 2017-06-14 18:26:29 +0000
99@@ -1,7 +1,7 @@
100 Source: anoise
101 Section: sound
102 Priority: extra
103-Standards-Version: 0.0.27
104+Standards-Version: 0.0.28
105 Maintainer: costales <costales.marcos@gmail.com>
106 Build-Depends: python-distutils-extra, debhelper (>=7)
107 Homepage: https://code.launchpad.net/anoise
108
109=== modified file 'setup.py'
110--- setup.py 2017-06-12 20:36:07 +0000
111+++ setup.py 2017-06-14 18:26:29 +0000
112@@ -1,6 +1,6 @@
113 #!/usr/bin/env python3
114
115-# ANoise 0.0.27 - http://launchpad.net/anoise
116+# ANoise 0.0.28 - http://launchpad.net/anoise
117 # Copyright (C) 2012-2015 Marcos Alvarez Costales https://launchpad.net/~costales
118 #
119 # ANoise is free software; you can redistribute it and/or modify
120@@ -29,7 +29,7 @@
121 # Setup stage
122 DistUtilsExtra.auto.setup(
123 name = "anoise",
124- version = "0.0.27",
125+ version = "0.0.28",
126 description = "Ambient Noise",
127 author = "Marcos Alvarez Costales https://launchpad.net/~costales",
128 author_email = "https://launchpad.net/~costales",

Subscribers

People subscribed via source and target branches

to all changes: