Merge lp:~cosmos-door/unity-settings-daemon/lp1514544 into lp:unity-settings-daemon

Proposed by Mitsuya Shibata
Status: Work in progress
Proposed branch: lp:~cosmos-door/unity-settings-daemon/lp1514544
Merge into: lp:unity-settings-daemon
Diff against target: 30 lines (+4/-4)
1 file modified
plugins/keyboard/gsd-keyboard-manager.c (+4/-4)
To merge this branch: bzr merge lp:~cosmos-door/unity-settings-daemon/lp1514544
Reviewer Review Type Date Requested Status
William Hua Pending
Unity Settings Daemon Development Team Pending
Review via email: mp+277042@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your work, I think the "us" layout is needed for keybindings to work cross layouts though (e.g have "ctrl-C" copying even if your current layout is japanese)

Unmerged revisions

4118. By Mitsuya Shibata

keyboard: use default layout only when layouts is empty. Fixes #1514544

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/keyboard/gsd-keyboard-manager.c'
2--- plugins/keyboard/gsd-keyboard-manager.c 2015-10-28 17:52:16 +0000
3+++ plugins/keyboard/gsd-keyboard-manager.c 2015-11-09 18:38:09 +0000
4@@ -1916,7 +1916,7 @@
5 gint i, n;
6 gchar **layouts = NULL;
7 gchar **variants = NULL;
8- gboolean have_default_layout = FALSE;
9+ gboolean use_default_layout = TRUE;
10
11 v = g_dbus_proxy_get_cached_property (priv->localed, "X11Layout");
12 if (v) {
13@@ -1952,14 +1952,14 @@
14 else
15 id = g_strdup (layouts[i]);
16
17- if (g_str_equal (id, DEFAULT_LAYOUT))
18- have_default_layout = TRUE;
19+ if (use_default_layout)
20+ use_default_layout = FALSE;
21
22 g_variant_builder_add (&builder, "(ss)", INPUT_SOURCE_TYPE_XKB, id);
23 g_free (id);
24 }
25
26- if (!have_default_layout)
27+ if (use_default_layout)
28 g_variant_builder_add (&builder, "(ss)", INPUT_SOURCE_TYPE_XKB, DEFAULT_LAYOUT);
29
30 g_settings_set_value (priv->input_sources_settings, KEY_INPUT_SOURCES, g_variant_builder_end (&builder));

Subscribers

People subscribed via source and target branches