Code review comment for lp:~cosmos-door/ubuntu/quantal/avarice/fix-ftbfs-1058667

On 7 October 2012 03:53, Andrew Starr-Bochicchio <email address hidden> wrote:
> Review: Approve
>
> Thanks for your work on this. Everything looks good, and I can confirm that this allows the package to build on quantal.
>
> I'm not sure if I actually agree with Dmitrijs' suggestion though. While it is a best practice to keep changes to the upstream source in quilt packages, for packages that originate in Debian we try to stay as close as possible. Usually this includes respecting the patch system, or lack thereof, that the Debian maintainer has chosen to use. That said, I'm going to go ahead and upload it. No reason to make you jump through anymore hoops.

Well it was status quo: package format 1.0 & no patches in debian.
Therefore no obvious way to add patches. The first iteration had .pc/*
and quilt patches applied all in a diff.gz. Witch is a bad mix. If a
package doesn't have any patch system today, the only sane way to add
a patch system is by converting to 3.0 (quilt) format, as it is the
most minimal way to add patches (one line + series&patches) with no
additional build dependencies or changes to debian/rules and no
conflicts at merges (well... almost ;) ).

Regards,

Dmitrijs.