Code review comment for lp:~cosmos-door/ubuntu/quantal/avarice/fix-ftbfs-1058667

Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

Thanks for your work on this. Everything looks good, and I can confirm that this allows the package to build on quantal.

I'm not sure if I actually agree with Dmitrijs' suggestion though. While it is a best practice to keep changes to the upstream source in quilt packages, for packages that originate in Debian we try to stay as close as possible. Usually this includes respecting the patch system, or lack thereof, that the Debian maintainer has chosen to use. That said, I'm going to go ahead and upload it. No reason to make you jump through anymore hoops.

review: Approve

« Back to merge proposal