Merge lp:~cosmos-door/ubuntu/oneiric/gnarwl/fix-ftbfs-lp771112 into lp:ubuntu/oneiric/gnarwl

Proposed by Mitsuya Shibata
Status: Merged
Merged at revision: 9
Proposed branch: lp:~cosmos-door/ubuntu/oneiric/gnarwl/fix-ftbfs-lp771112
Merge into: lp:ubuntu/oneiric/gnarwl
Diff against target: 109 lines (+48/-3)
7 files modified
.pc/applied-patches (+1/-0)
.pc/fix-gcc4.6.patch/src/Makefile (+20/-0)
debian/changelog (+6/-0)
debian/control (+2/-1)
debian/patches/fix-gcc4.6.patch (+16/-0)
debian/patches/series (+1/-0)
src/Makefile (+2/-2)
To merge this branch: bzr merge lp:~cosmos-door/ubuntu/oneiric/gnarwl/fix-ftbfs-lp771112
Reviewer Review Type Date Requested Status
Matthias Klose Approve
Ubuntu branches Pending
Review via email: mp+75559@code.launchpad.net

Description of the change

Fix FTBFS with GCC4.6 (LP: #771112)

This patch move $(LFLAGS) includes -l options to after
source code and object files list within $(CC) statement.

To post a comment you must log in.
Revision history for this message
Matthias Klose (doko) wrote :

it's no GCC-4.6 error, it's the linking order which is wrong. Uploaded with an updated changelog

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '.pc/applied-patches'
2--- .pc/applied-patches 2010-04-19 19:07:39 +0000
3+++ .pc/applied-patches 2011-09-15 15:13:57 +0000
4@@ -1,3 +1,4 @@
5 doc.patch
6 dbaccess.patch
7 data-makefile.patch
8+fix-gcc4.6.patch
9
10=== added directory '.pc/fix-gcc4.6.patch'
11=== added file '.pc/fix-gcc4.6.patch/.timestamp'
12=== added directory '.pc/fix-gcc4.6.patch/src'
13=== added file '.pc/fix-gcc4.6.patch/src/Makefile'
14--- .pc/fix-gcc4.6.patch/src/Makefile 1970-01-01 00:00:00 +0000
15+++ .pc/fix-gcc4.6.patch/src/Makefile 2011-09-15 15:13:57 +0000
16@@ -0,0 +1,20 @@
17+OBJ=config.o dbaccess.o util.o mailhandler.o
18+SOBJ=config.o dbaccess.o util.o
19+
20+catch:
21+ $(MAKE) -C ..
22+
23+all: clean compile
24+
25+compile: $(OBJ) $(SOBJ)
26+ $(CC) $(CFLAGS) $(LFLAGS) -o $(BIN) gnarwl.c $(OBJ)
27+ $(CC) $(CFLAGS) $(LFLAGS) -o $(SBIN) damnit.c $(SOBJ)
28+
29+clean:
30+ rm -f DEADJOE *.o *~ $(BIN) $(SBIN)
31+
32+install:
33+ mkdir -m 755 -p $(BINDIR) $(SBINDIR)
34+ install -m 755 -s $(BIN) $(BINDIR)
35+ install -m 755 -s $(SBIN) $(SBINDIR)
36+
37
38=== modified file 'debian/changelog'
39--- debian/changelog 2010-08-04 06:54:49 +0000
40+++ debian/changelog 2011-09-15 15:13:57 +0000
41@@ -1,3 +1,9 @@
42+gnarwl (3.6.dfsg-6ubuntu1) oneiric; urgency=low
43+
44+ * Fix FTBFS with GCC-4.6 (LP: #771112)
45+
46+ -- Mitsuya Shibata <mty.shibata@gmail.com> Thu, 15 Sep 2011 16:25:10 +0900
47+
48 gnarwl (3.6.dfsg-6) unstable; urgency=low
49
50 * Added package ed to list of dependecies ( Closes: #591598 )
51
52=== modified file 'debian/control'
53--- debian/control 2010-08-04 06:54:49 +0000
54+++ debian/control 2011-09-15 15:13:57 +0000
55@@ -1,7 +1,8 @@
56 Source: gnarwl
57 Section: mail
58 Priority: optional
59-Maintainer: Francesco Zanolin <francesco.zanolin@ingv.it>
60+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
61+XSBC-Original-Maintainer: Francesco Zanolin <francesco.zanolin@ingv.it>
62 Uploaders: Alessandro De Zorzi <lota@nonlontano.it>
63 Build-Depends: debhelper (>= 7), libldap2-dev, libgdbm-dev, po-debconf, quilt
64 Standards-Version: 3.9.0
65
66=== added file 'debian/patches/fix-gcc4.6.patch'
67--- debian/patches/fix-gcc4.6.patch 1970-01-01 00:00:00 +0000
68+++ debian/patches/fix-gcc4.6.patch 2011-09-15 15:13:57 +0000
69@@ -0,0 +1,16 @@
70+Fix FTBFS with GCC-4.6 (LP: #771112)
71+Index: gnarwl/src/Makefile
72+===================================================================
73+--- gnarwl.orig/src/Makefile 2011-09-15 16:21:11.912681045 +0900
74++++ gnarwl/src/Makefile 2011-09-15 16:22:10.022701535 +0900
75+@@ -7,8 +7,8 @@
76+ all: clean compile
77+
78+ compile: $(OBJ) $(SOBJ)
79+- $(CC) $(CFLAGS) $(LFLAGS) -o $(BIN) gnarwl.c $(OBJ)
80+- $(CC) $(CFLAGS) $(LFLAGS) -o $(SBIN) damnit.c $(SOBJ)
81++ $(CC) $(CFLAGS) -o $(BIN) gnarwl.c $(OBJ) $(LFLAGS)
82++ $(CC) $(CFLAGS) -o $(SBIN) damnit.c $(SOBJ) $(LFLAGS)
83+
84+ clean:
85+ rm -f DEADJOE *.o *~ $(BIN) $(SBIN)
86
87=== modified file 'debian/patches/series'
88--- debian/patches/series 2010-03-20 06:33:26 +0000
89+++ debian/patches/series 2011-09-15 15:13:57 +0000
90@@ -1,3 +1,4 @@
91 doc.patch
92 dbaccess.patch
93 data-makefile.patch
94+fix-gcc4.6.patch
95
96=== modified file 'src/Makefile'
97--- src/Makefile 2004-05-28 19:43:08 +0000
98+++ src/Makefile 2011-09-15 15:13:57 +0000
99@@ -7,8 +7,8 @@
100 all: clean compile
101
102 compile: $(OBJ) $(SOBJ)
103- $(CC) $(CFLAGS) $(LFLAGS) -o $(BIN) gnarwl.c $(OBJ)
104- $(CC) $(CFLAGS) $(LFLAGS) -o $(SBIN) damnit.c $(SOBJ)
105+ $(CC) $(CFLAGS) -o $(BIN) gnarwl.c $(OBJ) $(LFLAGS)
106+ $(CC) $(CFLAGS) -o $(SBIN) damnit.c $(SOBJ) $(LFLAGS)
107
108 clean:
109 rm -f DEADJOE *.o *~ $(BIN) $(SBIN)

Subscribers

People subscribed via source and target branches