Code review comment for lp:~cosmos-door/ubuntu-keyboard/japanese-keyboard-rebooted

Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Hi Mitsuya,

 I've just been re-reviewing this, and it looks great; but I've found one last issue, whereby the cursor keys don't work correctly whilst still in pre-edit. I'm wondering if it might be best to simply call Qt.inputMethod.commit() when pressing the cursor keys?

review: Needs Fixing

« Back to merge proposal