Merge lp:~cosmos-door/ssh-import-id/fix-1565275 into lp:ssh-import-id

[Mitsuya Shibata]

  * ssh_import_id/__init__.py:
    - add support to import multiple keys

[Mitsuya Shibata (cosmos-door)]

Note: Perhaps fetch_keys_lp() doesn't need to modify.

[Scott Moser (smoser)]

you're right, fetch_keys_lp does not need modification.
Please remove that change.
Feel free to test with my ssh keys (gh:smoser or lp:smoser) as I have multiple in both places.

I'd +1 the rest of the change though.

review: Needs Fixing

[lp:~cosmos-door/ssh-import-id/fix-1565275]

211. By Mitsuya Shibata on 2016-04-04

  * ssh_import_id/__init__.py:
    - remove unneeded modification for launchpad from previous commit.

[Mitsuya Shibata (cosmos-door)]

Thank you for review! I pushed commit to remove unneeded changes.

review: Needs Resubmitting

[Andrew Starr-Bochicchio (andrewsomething)]

Looks like the comment was addressed. Anything else holding this up? Love to see this SRUed in Ubuntu.

[Mitsuya Shibata (cosmos-door)]

I'm waiting to be merged...
Should I ping to developer or any ML?

[Scott Moser (smoser)]

review: Approve

[Mitsuya Shibata (cosmos-door)]

Thanks!

=== modified file 'ssh_import_id/__init__.py'
--- ssh_import_id/__init__.py	2016-02-18 20:38:58 +0000
+++ ssh_import_id/__init__.py	2016-04-04 15:56:30 +0000
@@ -284,6 +284,7 @@
 def fetch_keys_gh(ghid, useragent):
 	x_ratelimit_remaining = 'x-ratelimit-remaining'
 	help_url = 'https://developer.github.com/v3/#rate-limiting'
+	keys = ""
 	try:
 		url = "https://api.github.com/users/%s/keys" % (quote_plus(ghid))
 		headers = {'User-Agent': user_agent()}
@@ -297,7 +298,7 @@
 			print('GitHub REST API rate-limited this IP address. See %s' % help_url)
 			os._exit(1)
 		for keyobj in data:
-			keys = "%s %s@github/%s\n" % (keyobj['key'], ghid, keyobj['id'])
+			keys += "%s %s@github/%s\n" % (keyobj['key'], ghid, keyobj['id'])
 	except (Exception,):
 		e = sys.exc_info()[1]
 		sys.stderr.write("ERROR: %s\n" % (str(e)))