Merge lp:~corydodt/txgenshi/505689 into lp:txgenshi

Proposed by Cory Dodt
Status: Merged
Merged at revision: not available
Proposed branch: lp:~corydodt/txgenshi/505689
Merge into: lp:txgenshi
Diff against target: 158 lines (+27/-26)
8 files modified
ChangeLog (+8/-0)
README (+1/-1)
TODO (+3/-2)
bin/demo.tac (+0/-17)
txgenshi/test/example.py (+3/-1)
txgenshi/util.py (+8/-1)
txgenshidemo/demo.tac (+1/-1)
txgenshidemo/resources.py (+3/-3)
To merge this branch: bzr merge lp:~corydodt/txgenshi/505689
Reviewer Review Type Date Requested Status
Duncan McGreggor Approve
Review via email: mp+17115@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Cory Dodt (corydodt) wrote :

This makes it easier to run the tests after installation.

lp:~corydodt/txgenshi/505689 updated
35. By Cory Dodt

#505689: missed one

Revision history for this message
Duncan McGreggor (oubiwann) wrote :

Looks good!

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ChangeLog'
2--- ChangeLog 2008-07-18 15:51:29 +0000
3+++ ChangeLog 2010-01-11 01:44:13 +0000
4@@ -1,3 +1,11 @@
5+2010.01.10
6+
7+* Added unit tests
8+* Replaced getObjectData with a lazy evaluation scheme that will not cause
9+side effects to occur unless requested (by including the variable in a
10+template)
11+* Cleaned up organization of the demo
12+
13 2008.07.18
14
15 * Renamed myloaders.
16
17=== modified file 'README'
18--- README 2010-01-07 19:15:43 +0000
19+++ README 2010-01-11 01:44:13 +0000
20@@ -23,7 +23,7 @@
21
22 To see a demo of txGenshi's features, run::
23
24- twistd -yn demo/demo.tac
25+ twistd -yn txgenshidemo/demo.tac
26
27 Then visit http://localhost:8080/
28
29
30=== modified file 'TODO'
31--- TODO 2008-07-18 12:27:47 +0000
32+++ TODO 2010-01-11 01:44:13 +0000
33@@ -4,11 +4,12 @@
34 Bugs
35 ----
36 * Fix XInclude support
37+ * See https://bugs.launchpad.net/txgenshi/+bugs
38
39 Placeholders
40 ------------
41- * Update the demo.resources Genshi code with comments about usage.
42- * Remove print statements and pdb calls.
43+ * Update the txgenshidemo.resources Genshi code with comments about usage.
44+ * Remove pdb calls.
45
46 Version 0.0.1
47 -------------
48
49=== removed file 'bin/demo.tac'
50--- bin/demo.tac 2008-07-18 12:17:18 +0000
51+++ bin/demo.tac 1970-01-01 00:00:00 +0000
52@@ -1,17 +0,0 @@
53-from twisted.application import service
54-from twisted.application import strports
55-
56-from nevow import appserver
57-
58-from demo import resources
59-
60-# create the application
61-application = service.Application('Site')
62-
63-# setup the site root
64-root = resources.SiteRoot()
65-site = appserver.NevowSite(root)
66-
67-# setup the web server
68-server = strports.service('tcp:8080', site)
69-server.setServiceParent(application)
70
71=== modified file 'txgenshi/test/example.py'
72--- txgenshi/test/example.py 2010-01-07 19:15:43 +0000
73+++ txgenshi/test/example.py 2010-01-11 01:44:13 +0000
74@@ -9,14 +9,16 @@
75
76 from txgenshi.loader import genshifile
77
78+
79 class Apple:
80 color = "red"
81
82+
83 class GenshiMixPage(rend.Page):
84 """
85 Example page with genshi templates demo
86 """
87- docFactory = genshifile(sibpath(__file__, '../../demo/templates/genshimix.xhtml'))
88+ docFactory = genshifile(sibpath(__file__, '../../txgenshidemo/templates/genshimix.xhtml'))
89 addSlash = True
90
91 def __init__(self, username=None, *args, **kwds):
92
93=== modified file 'txgenshi/util.py'
94--- txgenshi/util.py 2008-07-18 12:05:00 +0000
95+++ txgenshi/util.py 2010-01-11 01:44:13 +0000
96@@ -192,13 +192,20 @@
97 'author_email': "oubiwann@divmod.com",
98 'url': txgenshi.projectURL,
99 'packages': find_packages(),
100- #'scripts': ['bin/txgenshi.tac'],
101 'long_description': catReST(
102 'README',
103 'DEPENDENCIES',
104 out=False),
105 'license': 'MIT',
106 'classifiers': txgenshi.classifiers,
107+ 'package_data': {
108+ 'txgenshidemo': ['demo.tac',
109+ 'templates/genshimix.xhtml',
110+ 'templates/genshiinclude.xhtml',
111+ 'templates/home.xhtml',
112+ 'templates/mystuff.xhtml',
113+ 'templates/yourstuff.xhtml',
114+ ]}
115 }
116
117
118
119=== renamed directory 'demo' => 'txgenshidemo'
120=== modified file 'txgenshidemo/demo.tac'
121--- demo/demo.tac 2010-01-07 19:27:46 +0000
122+++ txgenshidemo/demo.tac 2010-01-11 01:44:13 +0000
123@@ -3,7 +3,7 @@
124 """
125 from twisted.application import internet, service
126 from nevow.appserver import NevowSite
127-from demo.resources import SiteRoot
128+from txgenshidemo.resources import SiteRoot
129
130 port = 8080
131
132
133=== modified file 'txgenshidemo/resources.py'
134--- demo/resources.py 2010-01-07 19:15:43 +0000
135+++ txgenshidemo/resources.py 2010-01-11 01:44:13 +0000
136@@ -8,11 +8,11 @@
137
138 class MyStuffResource(rend.Page):
139 addSlash = True
140- docFactory = loaders.xmlfile('demo/templates/mystuff.xhtml')
141+ docFactory = loaders.xmlfile('txgenshidemo/templates/mystuff.xhtml')
142
143 class YourStuffResource(rend.Page):
144 addSlash = True
145- docFactory = loaders.xmlfile('demo/templates/yourstuff.xhtml')
146+ docFactory = loaders.xmlfile('txgenshidemo/templates/yourstuff.xhtml')
147
148 def __init__(self, username='', *args, **kwds):
149 super(YourStuffResource, self).__init__(*args, **kwds)
150@@ -23,7 +23,7 @@
151
152 class SiteRoot(rend.Page):
153 addSlash = True
154- docFactory = loaders.xmlfile('demo/templates/home.xhtml')
155+ docFactory = loaders.xmlfile('txgenshidemo/templates/home.xhtml')
156 child_mystuff = MyStuffResource()
157
158 def getUsernameFromCookie(self, context):

Subscribers

People subscribed via source and target branches

to all changes: