Code review comment for lp:~corey.bryant/ubuntu/trusty/python-boto/jenkins-2014-02-26

Revision history for this message
James Page (james-page) wrote :

Corey

Couple of comments

1) Assumption that home is /home/ubuntu

Might not be valid - I'd probably actually just create a tmp directory with the .ssh/known_hosts file and then override the HOME variable when running the test.

2) Could you detail in the changelog where you got the fix from - just for reference.

Makes it easier to drop when we get a new release.

Cheers

James

review: Needs Fixing

« Back to merge proposal