Merge lp:~corey.bryant/python-keystoneclient/juno-http_connect_timeout into lp:~ubuntu-server-dev/python-keystoneclient/juno

Proposed by Corey Bryant
Status: Merged
Merge reported by: Corey Bryant
Merged at revision: not available
Proposed branch: lp:~corey.bryant/python-keystoneclient/juno-http_connect_timeout
Merge into: lp:~ubuntu-server-dev/python-keystoneclient/juno
Diff against target: 52 lines (+33/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/fix-1368545.patch (+25/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~corey.bryant/python-keystoneclient/juno-http_connect_timeout
Reviewer Review Type Date Requested Status
Ubuntu Server Developers Pending
Review via email: mp+267384@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2015-08-06 09:28:41 +0000
3+++ debian/changelog 2015-08-07 17:11:23 +0000
4@@ -1,3 +1,10 @@
5+python-keystoneclient (1:0.10.1-0ubuntu1.2~cloud0) UNRELEASED; urgency=medium
6+
7+ * debian/patches/fix-1368545.patch: Changing the value type of
8+ http_connect_timeout to IntOpt. (LP: #1368545)
9+
10+ -- Jorge Niedbalski <jorge.niedbalski@canonical.com> Fri, 07 Aug 2015 11:20:52 -0300
11+
12 python-keystoneclient (1:0.10.1-0ubuntu1.1~cloud0) trusty-juno; urgency=medium
13
14 * SECURITY UPDATE: incorrect cert verification with ssl_insecure option
15
16=== added file 'debian/patches/fix-1368545.patch'
17--- debian/patches/fix-1368545.patch 1970-01-01 00:00:00 +0000
18+++ debian/patches/fix-1368545.patch 2015-08-07 17:11:23 +0000
19@@ -0,0 +1,25 @@
20+Description: Changing the value type of http_connect_timeout
21+
22+The value type of http_connect_timeout definition
23+is changed from Bool to Int value. Python treats
24+a value more than 1 as True but oslo config defines
25+Boolean values as 'true, '1', 'yes' and 'on'.
26+So http_connect_timeout is only configured 1 or None.
27+
28+Change-Id: I53075cc04d0ccea543f8e657279534208ed03058
29+Closes-bug: #1368545.
30+
31+Origin: upstream, https://review.openstack.org/#/c/126543
32+Bug-Ubuntu: https://bugs.launchpad.net/keystonemiddleware/+bug/1368545
33+
34+--- python-keystoneclient-0.7.1.orig/keystoneclient/middleware/auth_token.py
35++++ python-keystoneclient-0.7.1/keystoneclient/middleware/auth_token.py
36+@@ -212,7 +212,7 @@ opts = [
37+ help='Do not handle authorization requests within the'
38+ ' middleware, but delegate the authorization decision to'
39+ ' downstream WSGI components'),
40+- cfg.BoolOpt('http_connect_timeout',
41++ cfg.IntOpt('http_connect_timeout',
42+ default=None,
43+ help='Request timeout value for communicating with Identity'
44+ ' API server.'),
45
46=== modified file 'debian/patches/series'
47--- debian/patches/series 2015-08-06 09:28:41 +0000
48+++ debian/patches/series 2015-08-07 17:11:23 +0000
49@@ -1,2 +1,3 @@
50+fix-1368545.patch
51 CVE-2014-7144.patch
52 CVE-2015-1852.patch

Subscribers

People subscribed via source and target branches