Merge lp:~corey.bryant/cinder/2015.1-b1-0ubuntu3 into lp:~ubuntu-server-dev/cinder/kilo

Proposed by Corey Bryant on 2015-01-08
Status: Merged
Merged at revision: 215
Proposed branch: lp:~corey.bryant/cinder/2015.1-b1-0ubuntu3
Merge into: lp:~ubuntu-server-dev/cinder/kilo
Diff against target: 112 lines (+37/-41)
5 files modified
debian/changelog (+9/-0)
debian/cinder-common.logrotate (+1/-1)
debian/patches/fix-iscsi-initiator-exception.patch (+0/-39)
debian/patches/series (+1/-1)
debian/patches/skip-huaweistorac-delete-snapshot-success-test.patch (+26/-0)
To merge this branch: bzr merge lp:~corey.bryant/cinder/2015.1-b1-0ubuntu3
Reviewer Review Type Date Requested Status
Ubuntu Server Developers 2015-01-08 Pending
Review via email: mp+245877@code.launchpad.net
To post a comment you must log in.
215. By Corey Bryant on 2015-01-08

* d/p/fix-iscsi-initiator-exception.patch: Dropped. Abandoned upstream.
* d/p/skip-huaweistorac-delete-snapshot-success-test.patch: Handle OSError
  exception.
* d/cinder-common.logrotate: Apply to all cinder log files.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2015-01-08 14:20:02 +0000
3+++ debian/changelog 2015-01-08 18:32:42 +0000
4@@ -1,3 +1,12 @@
5+cinder (1:2015.1~b1-0ubuntu3) UNRELEASED; urgency=medium
6+
7+ * d/p/fix-iscsi-initiator-exception.patch: Dropped. Abandoned upstream.
8+ * d/p/skip-huaweistorac-delete-snapshot-success-test.patch: Handle OSError
9+ exception.
10+ * d/cinder-common.logrotate: Apply to all cinder log files.
11+
12+ -- Corey Bryant <corey.bryant@canonical.com> Thu, 08 Jan 2015 10:53:04 -0500
13+
14 cinder (1:2015.1~b1-0ubuntu2) vivid; urgency=medium
15
16 * Systemd enablement:
17
18=== modified file 'debian/cinder-common.logrotate'
19--- debian/cinder-common.logrotate 2015-01-08 14:18:28 +0000
20+++ debian/cinder-common.logrotate 2015-01-08 18:32:42 +0000
21@@ -1,4 +1,4 @@
22-/var/log/cinder/cinder-api.log {
23+/var/log/cinder/*.log {
24 daily
25 missingok
26 compress
27
28=== removed file 'debian/patches/fix-iscsi-initiator-exception.patch'
29--- debian/patches/fix-iscsi-initiator-exception.patch 2015-01-06 21:21:17 +0000
30+++ debian/patches/fix-iscsi-initiator-exception.patch 1970-01-01 00:00:00 +0000
31@@ -1,39 +0,0 @@
32-From 5e4ff519711e10fb938387bd87c4f262ca3c1435 Mon Sep 17 00:00:00 2001
33-From: Corey Bryant <corey.bryant@canonical.com>
34-Date: Tue, 6 Jan 2015 15:41:29 -0500
35-Subject: [PATCH] Handle ISCSIConnector.get_initiator() OSError
36-
37-Handle ISCSIConnector.get_initiator() OSError exception (errno=ENOENT)
38-when /etc/iscsi/initiatorname.iscsi doesn't exist.
39-
40-Closes-Bug: 1408087
41----
42- cinder/brick/initiator/connector.py | 5 ++++-
43- 1 file changed, 4 insertions(+), 1 deletion(-)
44-
45-diff --git a/cinder/brick/initiator/connector.py b/cinder/brick/initiator/connector.py
46-index 56d6c91..e6abab1 100644
47---- a/cinder/brick/initiator/connector.py
48-+++ b/cinder/brick/initiator/connector.py
49-@@ -13,6 +13,7 @@
50- # License for the specific language governing permissions and limitations
51- # under the License.
52-
53-+import errno
54- import os
55- import socket
56- import time
57-@@ -322,7 +323,9 @@ class ISCSIConnector(InitiatorConnector):
58- for l in lines.split('\n'):
59- if l.startswith('InitiatorName='):
60- return l[l.index('=') + 1:].strip()
61-- except putils.ProcessExecutionError:
62-+ except (putils.ProcessExecutionError, OSError) as err:
63-+ if isinstance(err, OSError) and err.errno != errno.ENOENT:
64-+ raise
65- msg = (_("Could not find the iSCSI Initiator File %s")
66- % file_path)
67- LOG.warn(msg)
68---
69-2.1.0
70-
71
72=== modified file 'debian/patches/series'
73--- debian/patches/series 2015-01-06 21:21:17 +0000
74+++ debian/patches/series 2015-01-08 18:32:42 +0000
75@@ -1,5 +1,5 @@
76+skip-huaweistorac-delete-snapshot-success-test.patch
77 fix-assert-raises-regex-tests.patch
78-fix-iscsi-initiator-exception.patch
79 skip-rtslib-test.patch
80 skip-ssl-tests.patch
81 fix-requirements.patch
82
83=== added file 'debian/patches/skip-huaweistorac-delete-snapshot-success-test.patch'
84--- debian/patches/skip-huaweistorac-delete-snapshot-success-test.patch 1970-01-01 00:00:00 +0000
85+++ debian/patches/skip-huaweistorac-delete-snapshot-success-test.patch 2015-01-08 18:32:42 +0000
86@@ -0,0 +1,26 @@
87+Description: Skip part of test that fails in chroot builds only.
88+Author: Corey Bryant <corey.bryant@canonical.com>
89+Forwarded: No
90+--- a/cinder/tests/test_huaweistorac.py
91++++ b/cinder/tests/test_huaweistorac.py
92+@@ -18,6 +18,7 @@
93+
94+ import mock
95+
96++import errno
97+ import os
98+ import re
99+ import tempfile
100+@@ -412,7 +413,11 @@
101+ mock__attach_volume.return_value = None
102+ mock__detach_volume.return_value = None
103+
104+- self.driver.delete_snapshot(test_snap)
105++ try:
106++ self.driver.delete_snapshot(test_snap)
107++ except OSError as err:
108++ if err.errno == errno.ENOENT:
109++ self.skipTest('Skipped by Ubuntu')
110+ self.assertEqual('0', FakeVbsClient.retcode)
111+
112+ mock_is_volume_connected.return_value = False

Subscribers

People subscribed via source and target branches